Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rook/Bishop Overload counting as Player Deaths #123

Closed
thatdudewon opened this issue Oct 13, 2017 · 7 comments
Closed

Rook/Bishop Overload counting as Player Deaths #123

thatdudewon opened this issue Oct 13, 2017 · 7 comments

Comments

@thatdudewon
Copy link

The skill(s) Rook/Bishop Overload for MCH, which blows up the turret pet for high damage, adds a death count to the Player, misleading information in active parsing that the player has died multiple times when they haven't every use.

Recreation: Just use the skill and ACT will count it as a death

*Combine Pets with Owner is Enabled

@ravahn
Copy link
Owner

ravahn commented Oct 14, 2017

Next version will filter out rook/bishop overload deaths when combine pet with owner is checked. I'll leave the rest as-is - other types of pet deaths will still appear as player deaths when combine pets with owner is enabled.

@Squall-Leonhart
Copy link

on the subject of machinest, I don't seem to see wildfire's damage either on the target or as outgoing from my character.

@ravahn
Copy link
Owner

ravahn commented Oct 15, 2017

Need more info for wildfire help...I will mention that if network parsing is disabled, it probably wont get captured as wildfire and will appear as an unknown DoT tick.

@Squall-Leonhart
Copy link

its was getting NaN'd in ACT, i just updated the plugin and attempted to reproduce it with logging on and its now working.

sorry, late alarm, ha.

@thatdudewon
Copy link
Author

thatdudewon commented Oct 16, 2017

@ravahn as of the latest update (1.5.1.10), Overdrive is still causing Killing marks on the Player as per the screenshot on a striking dummy (https://puu.sh/xZFrL/08210b4492.png)

@thatdudewon
Copy link
Author

thatdudewon commented Oct 16, 2017

Heres a better screencap of multiple uses on a dummy and how it displays on a skin:
(https://puu.sh/xZFQD/85dc21c9a9.png)
(https://puu.sh/xZFYa/d6cdc3a14b.png)

@ravahn
Copy link
Owner

ravahn commented Jan 27, 2019

This turned out to be a coding bug when I fixed it, under most scenarios (except the one I tested at the time) the code was not properly identifying the turret death lines. This will be fixed in the next release, 1.7.2.6.

@ravahn ravahn closed this as completed Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants