Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using namespace is not allowed in header file #17

Closed
GrbavaCigla opened this issue Apr 17, 2020 · 4 comments
Closed

Using namespace is not allowed in header file #17

GrbavaCigla opened this issue Apr 17, 2020 · 4 comments

Comments

@GrbavaCigla
Copy link

Hi, I am currently writing CMake configurations for this project, I noticed few very big mistakes.
First one is that you should never use using namespace ... in header files. Here is explanation for that: https://stackoverflow.com/questions/5849457/using-namespace-in-c-headers
Second you should add header guards, here is explanation how and why: https://www.learncpp.com/cpp-tutorial/header-guards/

@GrbavaCigla
Copy link
Author

Also when I remove "std.h" which only for windows, I get errors, I fixed a lot of them, but one is still there

@ebachard
Copy link

ebachard commented Apr 18, 2020

Hi,

@GrbavaCigla:

You can add: the way exceptions are implemented could be discussed too :-)

FYI, I completed the build on Linux writing a dumb CMakefile.txt, and I start some tests very soon.

TODO : I still have to fix all ffmpeg warnings, because the used API is obsolete+remains to implement something more modern.

Stay tuned :-)

In fact, just a question : on my side, I simply modified your makefile adding a new path for include dirs:

target_include_directories(${PROJECT_NAME} PUBLIC ${PROJECT_SOURCE_DIR}/source/ffmpeg-cpp )

I think it's more less boring than add #include "ffmpeg-cpp/(lot of .h files)" no ?

My current configuration is:

  • linux x86_64 (LnuxMint)
  • gcc-7.5 / g++-7.5
  • ffmpeg 4.2.2 (releases, built from sources)

ffmpeg -buildconf returns :

~ $ ffmpeg -buildconf
ffmpeg version 4.2.2 Copyright (c) 2000-2019 the FFmpeg developers
  built with gcc 7 (Ubuntu 7.5.0-3ubuntu1~18.04)
  configuration: --enable-pthreads --enable-shared --enable-pic --enable-opengl --enable-libpulse --enable-openal --enable-filter=deshake --enable-libmodplug --enable-libgme --enable-libv4l2 --enable-libopenjpeg --enable-vaapi --enable-libdav1d --enable-libwavpack --enable-gnutls --enable-libzmq --enable-protocol=https --enable-gcrypt --enable-protocol=ffrtmpcrypt --enable-protocol=ffrtmphttp --enable-protocol=rtmp --enable-protocol=rtmpe --enable-protocol=rtmps --enable-protocol=rtmpt --enable-protocol=rtmpte --enable-protocol=rtmpts --enable-libdrm
  libavutil      56. 31.100 / 56. 31.100
  libavcodec     58. 54.100 / 58. 54.100
  libavformat    58. 29.100 / 58. 29.100
  libavdevice    58.  8.100 / 58.  8.100
  libavfilter     7. 57.100 /  7. 57.100
  libswscale      5.  5.100 /  5.  5.100
  libswresample   3.  5.100 /  3.  5.100

  configuration:
    --enable-pthreads
    --enable-shared
    --enable-pic
    --enable-opengl
    --enable-libpulse
    --enable-openal
    --enable-filter=deshake
    --enable-libmodplug
    --enable-libgme
    --enable-libv4l2
    --enable-libopenjpeg
    --enable-vaapi
    --enable-libdav1d
    --enable-libwavpack
    --enable-gnutls
    --enable-libzmq
    --enable-protocol=https
    --enable-gcrypt
    --enable-protocol=ffrtmpcrypt
    --enable-protocol=ffrtmphttp
    --enable-protocol=rtmp
    --enable-protocol=rtmpe
    --enable-protocol=rtmps
    --enable-protocol=rtmpt
    --enable-protocol=rtmpte
    --enable-protocol=rtmpts
    --enable-libdrm

As reminder, the build log (removed some path for privacy reasons):

Scanning dependencies of target ffmpeg-cpp
[  1%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/decode_audio/decode_audio.cpp.o
[  3%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/decode_video/decode_video.cpp.o
[  5%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/demo/GeneratedAudioSource.cpp.o
[  7%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/demo/GeneratedVideoSource.cpp.o
[  9%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/demo/demo.cpp.o
[ 11%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/difference/difference.cpp.o
[ 13%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/encode_audio/encode_audio.cpp.o
[ 15%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/encode_video/encode_video.cpp.o
[ 17%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/AudioFormatConverter.cpp.o
[ 19%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/CodecDeducer.cpp.o
[ 21%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Codecs/AudioCodec.cpp.o
[ 23%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Codecs/Codec.cpp.o
[ 25%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Codecs/JPGCodec.cpp.o
[ 27%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Codecs/PNGCodec.cpp.o
[ 29%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Codecs/VP9Codec.cpp.o
[ 31%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Codecs/VideoCodec.cpp.o
[ 33%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp.o
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp: In member function ‘virtual void ffmpegcpp::AudioInputStream::AddStreamInfo(ffmpegcpp::ContainerInfo*)’:
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:46:38: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->properties = stream->codec->properties;
                                      ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:46:38: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->properties = stream->codec->properties;
                                      ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:46:38: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->properties = stream->codec->properties;
                                      ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:47:33: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->codec = stream->codec->codec;
                                 ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:47:33: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->codec = stream->codec->codec;
                                 ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:47:33: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->codec = stream->codec->codec;
                                 ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:48:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmin = stream->codec->qmin;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:48:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmin = stream->codec->qmin;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:48:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmin = stream->codec->qmin;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:49:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmax = stream->codec->qmax;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:49:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmax = stream->codec->qmax;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:49:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmax = stream->codec->qmax;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:50:39: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_width = stream->codec->coded_width;
                                       ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:50:39: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_width = stream->codec->coded_width;
                                       ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:50:39: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_width = stream->codec->coded_width;
                                       ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:51:40: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_height = stream->codec->coded_height;
                                        ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:51:40: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_height = stream->codec->coded_height;
                                        ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:51:40: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_height = stream->codec->coded_height;
                                        ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/AudioInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
[ 35%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/InputStream.cpp.o
[ 37%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/StreamData.cpp.o
[ 39%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp.o
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp: In member function ‘virtual void ffmpegcpp::VideoInputStream::AddStreamInfo(ffmpegcpp::ContainerInfo*)’:
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:47:38: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->properties = stream->codec->properties;
                                      ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:47:38: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->properties = stream->codec->properties;
                                      ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:47:38: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->properties = stream->codec->properties;
                                      ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:48:33: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->codec = stream->codec->codec;
                                 ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:48:33: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->codec = stream->codec->codec;
                                 ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:48:33: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->codec = stream->codec->codec;
                                 ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:49:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmin = stream->codec->qmin;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:49:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmin = stream->codec->qmin;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:49:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmin = stream->codec->qmin;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:50:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmax = stream->codec->qmax;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:50:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmax = stream->codec->qmax;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:50:32: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->qmax = stream->codec->qmax;
                                ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:51:39: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_width = stream->codec->coded_width;
                                       ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:51:39: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_width = stream->codec->coded_width;
                                       ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:51:39: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_width = stream->codec->coded_width;
                                       ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:52:40: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_height = stream->codec->coded_height;
                                        ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:52:40: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_height = stream->codec->coded_height;
                                        ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:52:40: warning: ‘AVStream::codec’ is deprecated [-Wdeprecated-declarations]
   codecContext->coded_height = stream->codec->coded_height;
                                        ^~~~~
In file included from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/ffmpeg.h:11:0,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.h:3,
                 from ./ffmpeg-cpp2/source/ffmpeg-cpp/ffmpeg-cpp/Demuxing/VideoInputStream.cpp:1:
/usr/local/include/libavformat/avformat.h:885:21: note: declared here
     AVCodecContext *codec;
                     ^~~~~
[ 41%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/FFmpegException.cpp.o
[ 43%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Frame_Sinks/AudioEncoder.cpp.o
[ 45%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Frame_Sinks/AudioFilter.cpp.o
[ 47%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Frame_Sinks/Filter.cpp.o
[ 49%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Frame_Sinks/FrameSinkStream.cpp.o
[ 50%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Frame_Sinks/OneInputFrameSink.cpp.o
[ 52%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Frame_Sinks/VideoEncoder.cpp.o
[ 54%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Frame_Sinks/VideoFilterInput.cpp.o
[ 56%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/FrameContainer.cpp.o
[ 58%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Muxing/AudioOutputStream.cpp.o
[ 60%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Muxing/Muxer.cpp.o
[ 62%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Muxing/OutputStream.cpp.o
[ 64%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Muxing/VideoOutputStream.cpp.o
[ 66%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/OpenCodec.cpp.o
[ 68%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Sources/Demuxer.cpp.o
[ 70%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Sources/EncodedFileSource.cpp.o
[ 72%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Sources/RawAudioDataSource.cpp.o
[ 74%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Sources/RawAudioFileSource.cpp.o
[ 76%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Sources/RawVideoDataSource.cpp.o
[ 78%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/Sources/RawVideoFileSource.cpp.o
[ 80%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/VideoFormatConverter.cpp.o
[ 82%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/codecs/H264NVEncCodec.cpp.o
[ 84%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/ffmpeg-cpp/codecs/H265NVEncCodec.cpp.o
[ 86%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/filtering_audio/filtering_audio.cpp.o
[ 88%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/filtering_video/filtering_video.cpp.o
[ 90%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/print_info/print_info.cpp.o
[ 92%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/remuxing/remuxing.cpp.o
[ 94%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/simple_interface/SimpleInterface.cpp.o
[ 96%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/simple_interface/dllmain.cpp.o
[ 98%] Building CXX object CMakeFiles/ffmpeg-cpp.dir/source/ffmpeg-cpp/simple_interface_demo/example.cpp.o
[100%] Linking CXX static library libffmpeg-cpp.a
[100%] Built target ffmpeg-cpp


@TechnikEmpire
Copy link

@GrbavaCigla Where are header guards not used? I see #pragma once everwhere.

@GrbavaCigla
Copy link
Author

@TechnikEmpire Yeah, sorry for that, I noticed it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants