-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using namespace is not allowed in header file #17
Comments
Also when I remove "std.h" which only for windows, I get errors, I fixed a lot of them, but one is still there |
Hi, You can add: the way exceptions are implemented could be discussed too :-) FYI, I completed the build on Linux writing a dumb CMakefile.txt, and I start some tests very soon. TODO : I still have to fix all ffmpeg warnings, because the used API is obsolete+remains to implement something more modern. Stay tuned :-) In fact, just a question : on my side, I simply modified your makefile adding a new path for include dirs:
I think it's more less boring than add #include "ffmpeg-cpp/(lot of .h files)" no ? My current configuration is:
ffmpeg -buildconf returns :
As reminder, the build log (removed some path for privacy reasons):
|
@GrbavaCigla Where are header guards not used? I see |
@TechnikEmpire Yeah, sorry for that, I noticed it later. |
Hi, I am currently writing CMake configurations for this project, I noticed few very big mistakes.
First one is that you should never use
using namespace ...
in header files. Here is explanation for that: https://stackoverflow.com/questions/5849457/using-namespace-in-c-headersSecond you should add header guards, here is explanation how and why: https://www.learncpp.com/cpp-tutorial/header-guards/
The text was updated successfully, but these errors were encountered: