Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [bug]: using v1 gives node16 deprecation warnings #21

Open
1 task done
joernott opened this issue Feb 6, 2024 · 6 comments · May be fixed by #22
Open
1 task done

🐛 [bug]: using v1 gives node16 deprecation warnings #21

joernott opened this issue Feb 6, 2024 · 6 comments · May be fixed by #22
Assignees
Labels
bug Something isn't working

Comments

@joernott
Copy link

joernott commented Feb 6, 2024

🐛 What happened?

We start seeing deprecation warnings aboud node16 when using raven-actions/actionlint@v1:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

🔬 How to reproduce?

Call actionlint action

🏗️ Code Sample / Log

[...]
  actionlint:
    needs: ['init', 'begin_report_phase']
    if: ${{ always() && needs.init.outputs.actionlint_skip != 'true' }}
    runs-on: ${{ fromJSON(inputs.runs_on) }}
    steps:
      - name: Install npm on private runner
        if: ${{ inputs.runs_on != '"ubuntu-latest"'}}
        run: |
          NPM=$(type -p 'npm'||true)
          if [ -z "${NPM}" ]; then
            echo -e "\033[0;35m###  Installing npm ###\033[0m"
            sudo DEBIAN_FRONTEND=noninteractive apt-get -qq update
            sudo apt-get -qq install npm
          fi

      - name: Checkout
        id: checkout
        uses: actions/checkout@v4

      - name: Run actionlint
        id: actionlint
        uses: raven-actions/actionlint@v1

🌌 Environment (actionlint action)

1.0.3

🌌 Environment (actionlint)

1.6.26-Linux-X64

🌌 Environment (GitHub Runner OS)

Linux

📷 Screenshots

No response

📈 Expected behavior

actions/cache is upgraded to v4 to remove the warning

📎 Additional context

No response

📜 Code of Conduct

  • I agree to follow this project's Code of Conduct.
@joernott joernott added the bug Something isn't working label Feb 6, 2024
@mvanduijker
Copy link

mvanduijker commented Feb 21, 2024

It should have been fixed with this #20
We have to wait for a new release.

@DariuszPorowski
Copy link
Collaborator

Will review, bump deps, test and release new one around end of 1st week of March.

@DariuszPorowski DariuszPorowski self-assigned this Mar 9, 2024
@DariuszPorowski DariuszPorowski linked a pull request Mar 9, 2024 that will close this issue
9 tasks
@mvanduijker
Copy link

any way I can help to get this released?

@pakosak
Copy link

pakosak commented May 13, 2024

any update on the release @DariuszPorowski ?

@DariuszPorowski
Copy link
Collaborator

@mvanduijker @pakosak currently this PR is a blocker: #22
After will solve it, then breaking change (v2 release) will happen with switch to node20

@rindeal
Copy link

rindeal commented May 22, 2024

So, that's a won't fix for this simple v1 tag move. Until v2 then:

        uses: raven-actions/actionlint@ea4eb57846a36a6faefbdc2d9ac873da9057c1bb

Looking forward, thanks for your work. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants