New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple h1 headers - Banner Block and Masthead Block #127

Open

cudevmaxwell opened this issue Jun 30, 2021 · 0 comments

Contributor

cudevmaxwell commented Jun 30, 2021

Describe the bug
Both the Banner and Masthead blocks use an h1 header.

Expected behavior
The Banner block should only use an h2 element. It's already supported in the CSS. https://github.com/ravendesignsystem/rds/blob/master/src/_blocks/banner/_banner.scss#L23
Or the Masthead should not use a header element at all, which I think makes the most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment