Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish tutorial #12

Open
mrhappyasthma opened this issue Oct 10, 2021 · 5 comments
Open

Finish tutorial #12

mrhappyasthma opened this issue Oct 10, 2021 · 5 comments

Comments

@mrhappyasthma
Copy link
Contributor

The following sections are empty:

  • Implementing GameInProgressPhase
  • Implementing GameEndedPhase

Also the very last sentence in https://ravens.dev/tutorial/#launching-the-game is an incomplete sentence.

(There may be more but I'm still working my way through it.)

@mrhappyasthma
Copy link
Contributor Author

Another issue:

By the time the 'Launching the Game' section, the UI isn't really complete. The table just renders as empty and the action handler does not appear to be configured.

The actions are defined in processAction() but they never appear to be triggered. It's missing the this.props.client.sendAction() call.

@mrhappyasthma
Copy link
Contributor Author

The UI css is not fully established by that point either. At a minimum we probably need table td to have the border color and size, so that it's better visible.

@mrhappyasthma
Copy link
Contributor Author

I have a local change ready for the tap handling section. But it's dependent on a bunch of the other PRs landing, so I'll just hold off until those get resolved.

@mrhappyasthma
Copy link
Contributor Author

Dependent PRs are in. I will propose some more PRs to finish up the rest of the tutorial.

@mrhappyasthma
Copy link
Contributor Author

The last section missing is the GameInProgressPhase logic. That phase has the most logic, so this section will take some time. But adding it will complete the tutorial! :)

https://ravens.dev/tutorial/#implementing-gameinprogressphase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant