Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mode of files created in /tmp #42

Closed
keithw opened this issue Dec 31, 2013 · 4 comments
Closed

Fix mode of files created in /tmp #42

keithw opened this issue Dec 31, 2013 · 4 comments

Comments

@keithw
Copy link
Collaborator

keithw commented Dec 31, 2013

umask should be user readable.

@anirudhSK
Copy link
Collaborator

I remember addressing this, but I don't remember which commit.

@ravinet
Copy link
Owner

ravinet commented Mar 28, 2014

We had fixed the files stored by recordshell to be user readable. Currently, the files created by replayshell (eg. error files, access logs) are in /tmp and are not user-readable.

@anirudhSK
Copy link
Collaborator

This needs to be fixed, because WebServer will be running with elevated privileges and hence could erase an old file belonging to the same user in /tmp/ (with very low probability).

On second thought, since these files are created using mkstemp, they are guaranteed to be unique (or return a non-zero value, if not).

@keithw
Copy link
Collaborator Author

keithw commented Jul 4, 2014

It seems to be a POSIX requirement that mkstemp() files be mode 0600. I guess we can leave it.

@keithw keithw closed this as completed Jul 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants