-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mode of files created in /tmp #42
Comments
I remember addressing this, but I don't remember which commit. |
We had fixed the files stored by recordshell to be user readable. Currently, the files created by replayshell (eg. error files, access logs) are in /tmp and are not user-readable. |
This needs to be fixed, because WebServer will be running with elevated privileges and hence could erase an old file belonging to the same user in /tmp/ (with very low probability). On second thought, since these files are created using mkstemp, they are guaranteed to be unique (or return a non-zero value, if not). |
It seems to be a POSIX requirement that mkstemp() files be mode 0600. I guess we can leave it. |
umask should be user readable.
The text was updated successfully, but these errors were encountered: