Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce backwards compatibility for multiple language support #28

Closed
raviriley opened this issue May 26, 2021 · 5 comments · Fixed by #47
Closed

Introduce backwards compatibility for multiple language support #28

raviriley opened this issue May 26, 2021 · 5 comments · Fixed by #47
Assignees
Labels
bug Something isn't working

Comments

@raviriley
Copy link
Owner

Is your feature request related to a problem? Please describe.

The current implementation of locales is not backwards compatible

Describe the solution you'd like

if statements for every usage of locales, so that if the user has no locales in any of their YAML files everything behaves like it would before the implementation

@rbenitezpagan if you get the chance, could you go in and add the if statements? You know the implementation better than I do since you wrote it.

@rbenitezpagan
Copy link
Contributor

rbenitezpagan commented May 26, 2021

@raviriley Yes, I'll work on it. Assign it to me. 👍

The implementation basically just added [site.locale] to the site.data.sitetext.<var> = site.data.sitetext[site.locale].<var> so it was not really a major change.

@raviriley
Copy link
Owner Author

Sounds good, thanks @rbenitezpagan!

@fmitchell
Copy link

fmitchell commented Jul 28, 2021

Letting you all know that I think this commit 34e5e85 broke my site that, I believe, is still dependent on the old structure.

Screenshot: https://share.getcloudapp.com/qGuJPPyb

The menu, middle section, and some other parts don't show up. I'm going to attempt to fix it based on the changes in that PR.

@raviriley raviriley added the bug Something isn't working label Aug 26, 2021
@raviriley
Copy link
Owner Author

Thanks @fmitchell! This issue is high priority. @rbenitezpagan I can take this if you'd like!

@rbenitezpagan
Copy link
Contributor

@raviriley This fell of my radar. You are welcome to tackle it.

I think you could add a default with site.data.sitetext.<var> and that should be enough.

@raviriley raviriley self-assigned this Aug 27, 2021
@raviriley raviriley added this to To do in Theme Functionality Sep 1, 2021
@raviriley raviriley moved this from To do to Done - Structure/Function in Theme Functionality Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Theme Functionality
  
Done - Structure/Function
Development

Successfully merging a pull request may close this issue.

3 participants