Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program Hangs When a Thread is not an image #10

Closed
dionytadema opened this issue Dec 8, 2016 · 3 comments
Closed

Program Hangs When a Thread is not an image #10

dionytadema opened this issue Dec 8, 2016 · 3 comments
Assignees
Labels

Comments

@dionytadema
Copy link

dionytadema commented Dec 8, 2016

RCW hangs on setting a background if the thread it selected is not an image thread, this is an issue because the reddit i want to use also contains other forms of media such as albums and videos (r/eveporn)

included log
RWC.txt

@dionytadema
Copy link
Author

dionytadema commented Dec 8, 2016

i looked into the code, an easy fix would be to do a check to see if the URL ends in a supported image format in the setwallpaper fucntion

an additional option would be to include a list of popular image hosting sites in the reddit search query, but that may exclude some post if they host their image on a site not included list. But this could also be left up to the user as this is possible already

@Rawns
Copy link
Owner

Rawns commented Dec 8, 2016

Thanks for the info. I'll get this ironed out for the next release. :)

@Rawns Rawns self-assigned this Dec 8, 2016
@Rawns Rawns added the bug label Dec 8, 2016
@Rawns
Copy link
Owner

Rawns commented Feb 6, 2017

Added a check to ensure URL is for an image in 1.0.8.5

@Rawns Rawns closed this as completed Feb 6, 2017
@Rawns Rawns added Fixed and removed bug labels Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants