Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fixed-height minibuffer, bind resize-mini-windows appropriately #35

Closed
clemera opened this issue Mar 27, 2020 · 5 comments
Closed

Comments

@clemera
Copy link
Collaborator

clemera commented Mar 27, 2020

When there are less actual candidates than selectrum-num-candidates-displayed specifies the minibuffer pops up at a lesser height than usual. I think that is annoying because my eyes are used to see the prompt at a higher position. I would like to be able to always give it the same height regardless how many candidates are available. This could be by default or by adding a user option, what do you think?

@clemera
Copy link
Collaborator Author

clemera commented Mar 27, 2020

I just stumbled across a related problem: The variable resize-mini-windows controls how minibuffer should resize, when set to nil selectrum is not able to show its candidates at all so it should probably be let bound to grow-only.

@raxod502
Copy link
Member

I would like to be able to always give it the same height regardless how many candidates are available.

Yep, sounds reasonable. It should be a new user option, disabled by default.

it should probably be let bound to grow-only

Also true. I didn't know about this variable before, thanks for pointing it out.

@raxod502 raxod502 changed the title User option for consistend height of minibuffer Allow fixed-height minibuffer, bind resize-mini-windows appropriately Mar 31, 2020
raxod502 added a commit that referenced this issue Apr 17, 2020
raxod502 added a commit that referenced this issue Apr 18, 2020
@raxod502
Copy link
Member

Let me know what you think.

@raxod502 raxod502 added the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Apr 18, 2020
@clemera
Copy link
Collaborator Author

clemera commented Apr 18, 2020

Looks good to me, alternatively we could check for window-height and use enlarge-window but I guess there is no problem to insert empty lines.

@raxod502
Copy link
Member

I like this solution as it means there's only one way that we set the window height, which is by inserting text. Thanks.

@raxod502 raxod502 removed the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants