Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink to libgit2.pc.in is named libgit2.pc #497

Closed
tastytea opened this issue Mar 15, 2020 · 2 comments
Closed

Symlink to libgit2.pc.in is named libgit2.pc #497

tastytea opened this issue Mar 15, 2020 · 2 comments

Comments

@tastytea
Copy link

tastytea commented Mar 15, 2020

What's wrong

The symlink from the build directory to the repo is wrong, the .in is dropped.

It is: […]/build/libgit/libgit2/libgit2.pc[…]/repos/libegit2/libgit2/libgit2.pc.in
It should be: […]/build/libgit/libgit2/libgit2.pc.in[…]/repos/libegit2/libgit2/libgit2.pc.in

Update: It's not limited to symlinks, the same happens if I set straight-use-symlinks to nil.

Directions to reproduce

(setq straight-repository-branch "develop")
(defvar bootstrap-version)
(let ((bootstrap-file
       (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
      (bootstrap-version 5))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously
         "https://raw.githubusercontent.com/raxod502/straight.el/develop/install.el"
         'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))

(straight-use-package 'libgit)
% ls -l ~/.emacs.d/straight/build/libgit/libgit2/libgit2.pc*
[…] /home/tastytea/.emacs.d/straight/build/libgit/libgit2/libgit2.pc -> /home/tastytea/.emacs.d/straight/repos/libegit2/libgit2/libgit2.pc.in

Version information

  • Emacs version: GNU Emacs 27.0.90 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, cairo version 1.16.0) of 2020-03-11
  • Operating system: Gentoo Linux
@tastytea tastytea added the bug label Mar 15, 2020
raxod502 added a commit that referenced this issue Mar 20, 2020
There was a logic change in MELPA since I wrote this code:
melpa/package-build@b2b474a
@raxod502 raxod502 added this to the 1.0 milestone Mar 20, 2020
@raxod502
Copy link
Member

Should be fixed now. Thanks for the report.

@tastytea
Copy link
Author

Thanks. I can confirm that it's fixed.

raxod502 added a commit that referenced this issue Mar 31, 2020
There was a logic change in MELPA since I wrote this code:
melpa/package-build@b2b474a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants