Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the appropriate quote in Windows (#393) #473

Merged
merged 5 commits into from
Feb 9, 2020
Merged

Use the appropriate quote in Windows (#393) #473

merged 5 commits into from
Feb 9, 2020

Conversation

r-darwish
Copy link
Contributor

This is probably not the ideal solution, but it makes stuff work until someone come up with a better one

raxod502
raxod502 requested changes Jan 31, 2020
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI reports a long line. Also, could you add a comment linking to the issue where this is discussed? The code is very confusing to anyone who knows how process invocation is supposed to work, unless they have that context.

@r-darwish
Copy link
Contributor Author

Will do. I’ll probably get to that in Sunday

raxod502
raxod502 approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

raxod502
raxod502 requested changes Feb 2, 2020
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually CI is still failing.

@r-darwish
Copy link
Contributor Author

I pushed another fix. Seems to be okay now

@r-darwish
Copy link
Contributor Author

Sorry for bugging, but is there anything else that I should do before we can merge?

@r-darwish r-darwish mentioned this pull request Feb 9, 2020
Closed
raxod502
raxod502 approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's all good. Thank you for your patience.

@raxod502 raxod502 merged commit 19216df into radian-software:develop Feb 9, 2020
@raxod502 raxod502 mentioned this pull request Feb 9, 2020
Closed
@hlissner hlissner mentioned this pull request Feb 9, 2020
Closed
raxod502 added a commit that referenced this pull request Feb 14, 2020
@r-darwish @raxod502
[Backport] Use the appropriate quote in Windows (#393) (#473)
ed54b62 
Co-authored-by: Radon Rosborough <radon.neon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxod502 raxod502 raxod502 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-darwish @raxod502