Add more descriptive text for missing translations #91
Conversation
|
Visit the preview URL for this PR (updated for commit 6910ab9): https://andaxapp--pr91-missing-translation-4gq41a4w.web.app (expires Sun, 22 May 2022 19:57:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
| @@ -23,7 +23,7 @@ class NodeDisplay extends StatelessWidget { | |||
| final play = context.watch<PlayScreenState>(); | |||
| final audioPlayer = play.audio; | |||
| final actor = play.actors[node.actorId]; | |||
| final text = play.tr.node(node, allowEmpty: true); | |||
There was a problem hiding this comment.
[issue] Sometimes nodes need to have no text. For example, when a node used as cell-writer or as a logical route. Or even media-only nodes that just show image \ audio. For such nodes no message card should be displayed. Without allowEmpty, we have no way to know when a node is not indented to have any text.
[suggestion, non-blocking] Alternatively, we might introduce bool display field for Node model, with corresponding toggle in the Node Editor. This will be additionally useful for the timer management, as there's no need to wait and show the typing indicator for such "logic" nodes.
Or we can take it even further, and make an array of new Content objects for Node. The Content class will have various descendants such as TextContent, AudioContent, ImageContent, etc., and editors will be able to array them in the editor, controlling the contents of a node. And so a "logic" node will be that with empty contents array.
There was a problem hiding this comment.
An example of logic (or non-display) node from the tutorial:
Closes #76