Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make player selection consistent for all actions #5

Closed
ray-kast opened this issue Mar 5, 2022 · 2 comments
Closed

Make player selection consistent for all actions #5

ray-kast opened this issue Mar 5, 2022 · 2 comments

Comments

@ray-kast
Copy link
Owner

ray-kast commented Mar 5, 2022

Presently when the daemon is searching for a player to execute a command, it uses the first player which can successfully respond to said command. However, due to varying capabilities of different players, this can result on different commands being sent to different players, often in counterintuitive ways.

This ticket may require bumping the D-Bus protocol to v2 for allowing the methods to accept a map of player query filters, so that a single unified player search function can be implemented while still allowing users similar functionality to v1 if desired.

@ray-kast
Copy link
Owner Author

Tentative fix for this issue in 7280277. Does not allow for user control of search scope and bumping the protocol version to v2 to accommodate search flags may still be desirable.

@ray-kast
Copy link
Owner Author

Closed with v1.6.0. May reopen an issue for configurable player querying for v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant