Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelisting pages with addon icon adds the blocking-pages address #11

Closed
sunkup opened this issue Jun 14, 2019 · 1 comment
Closed

Whitelisting pages with addon icon adds the blocking-pages address #11

sunkup opened this issue Jun 14, 2019 · 1 comment

Comments

@sunkup
Copy link

sunkup commented Jun 14, 2019

Clicking the addon icon while in whitelist mode only adds addon-address (moz-extension://[...]/) to the whitelist! I do not think that is intended and I would love to see it add the domain the user is about to access to the whitelist with a configurable wildcard setting for subdomains, paths and params instead.
@sunkup sunkup mentioned this issue Jun 14, 2019
Closed
@sunkup sunkup changed the title Adding sites to whitelist with addon icon Adding sites to whitelist with addon icon will add the blocking-pages address Jun 14, 2019
@sunkup sunkup changed the title Adding sites to whitelist with addon icon will add the blocking-pages address Adding sites to whitelist with addon icon adds the blocking-pages address Jun 14, 2019
@sunkup sunkup changed the title Adding sites to whitelist with addon icon adds the blocking-pages address Whitelisting pages with addon icon adds the blocking-pages address Jun 14, 2019
@ray-lothian
Copy link
Owner

True, the warning message is changed. I am not going to perform any action though, since we already have the button in the page based on #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunkup @ray-lothian