Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first iteration of Github Actions workflow to build and publish to Python Package Index (PyPI) #26

Merged
merged 15 commits into from Jan 5, 2023

Conversation

pfaraone
Copy link
Collaborator

@pfaraone pfaraone commented Dec 22, 2022

This PR introduces a Github Action workflow that publishes tagged commits to PyPI and untagged commits to TestPyPi unconditionally if there is a version change

Usage

git add README.md
git commit -m "Added foo section to the README"
git tag 0.1.5
git push origin 0.1.5

Prerequisites

  • PyPI and TestPyPI API tokens generated and then set as PYPI_API_TOKEN and TEST_PYPI_API_TOKEN respectively (PyPI currently set, TestPyPi pending)

Related links / References

Testing

Identical workflow executed on my fork of Deltacat - https://github.com/pfaraone/deltacat/actions

Discussion

  • Dependency installation from requirements.txt is taking 55 seconds (45% of total execution time) because we are using a dependency range instead of a pinned dependency (e.g., "pyarrow >= 8.0.0")

@pfaraone pfaraone self-assigned this Dec 22, 2022
@pfaraone pfaraone added the enhancement New feature or request label Dec 22, 2022
@pfaraone pfaraone changed the title [chore] Added first iteration of build and publish to pypi workflow Added first iteration of build and publish to pypi workflow Dec 22, 2022
@pfaraone pfaraone changed the title Added first iteration of build and publish to pypi workflow Add first iteration Github Actions workflow to build and publish to Python Package Index (PyPI) Dec 22, 2022
@pfaraone pfaraone changed the title Add first iteration Github Actions workflow to build and publish to Python Package Index (PyPI) Add first iteration of Github Actions workflow to build and publish to Python Package Index (PyPI) Dec 22, 2022
requirements.txt Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@raghumdani raghumdani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Let's see if we can make requirements.txt changes.

pfaraone and others added 5 commits December 23, 2022 07:38
Co-authored-by: Raghavendra M Dani <raghumdani@gmail.com>
Signed-off-by: pf <19919899+pfaraone@users.noreply.github.com>
Copy link
Collaborator

@raghumdani raghumdani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

requirements.txt Outdated Show resolved Hide resolved
@rkenmi rkenmi self-requested a review January 4, 2023 19:06
Copy link
Member

@rkenmi rkenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@valiantljk valiantljk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants