New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first iteration of Github Actions workflow to build and publish to Python Package Index (PyPI) #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Let's see if we can make requirements.txt
changes.
Co-authored-by: Raghavendra M Dani <raghumdani@gmail.com> Signed-off-by: pf <19919899+pfaraone@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR introduces a Github Action workflow that publishes tagged commits to PyPI and untagged commits to TestPyPi unconditionally if there is a version change
Usage
Prerequisites
Related links / References
Testing
Identical workflow executed on my fork of Deltacat - https://github.com/pfaraone/deltacat/actions
Discussion
requirements.txt
is taking 55 seconds (45% of total execution time) because we are using a dependency range instead of a pinned dependency (e.g.,"pyarrow >= 8.0.0"
)