-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Allow different LocalQueue label for head and worker groups #2099
Comments
This would break a lot of semantics. A better practice, that is already supported, is to define two resource flavors for each CQ, one with GPUs, one without. You can use affinities or taints/tolerations to match heads and workers to each of the flavors. https://kueue.sigs.k8s.io/docs/concepts/resource_flavor/#resourceflavor-labels |
Thanks @kevin85421 @alculquicondor , this makes a lot sense. I'll try the two flavors setup instead. |
Hi @alculquicondor , we did some quick tests and it appears that heads and workers cannot be admitted to different flavors at the same time. I'm wondering if you have existing setups/examples that could share with me for reference? Here is some controller logs related
|
@shaowei-su can you share your full RayJob yaml and your ClusterQueue? (redact any internal details) |
Thanks @andrewsykim, I just got it working by deleting & re-apply the CRDs (resource flavors, cluster queues). It was not working with in-place editing for some reason. Closing this issue and thanks for looking into this! |
Search before asking
Description
Per doc (https://kueue.sigs.k8s.io/docs/tasks/run/rayjobs/), the LocalQueue label is a global settings that will be applied to both head and worker pods. As a result, we could accidentally schedule head pod (which usually can be lightweight) in the scarce node types reserved for workers and inherit all the ResourceFlavor labels and tolerations.
Use case
No response
Related issues
#2098
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: