Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Restart worker pod when raylet exited #62

Closed
2 tasks done
chenk008 opened this issue Oct 14, 2021 · 1 comment · Fixed by #77
Closed
2 tasks done

[Feature] Restart worker pod when raylet exited #62

chenk008 opened this issue Oct 14, 2021 · 1 comment · Fixed by #77
Labels
enhancement New feature or request

Comments

@chenk008
Copy link
Contributor

chenk008 commented Oct 14, 2021

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

For now, ray-operator generate worker pod command

ulimit -n 65536; ray start  --node-ip-address=$MY_POD_IP  --redis-password=LetMeInRay  --address=raycluster-heterogeneous-head-svc:6379  && sleep infinity

If the raylet in worker pod exited, the raylet don't restart, so the pod will be useless without raylet.

Use case

If the raylet in worker pod exited, the raylet should restart.

One option is starting ray with --block and delete the sleep infinity.
Another option is restarting the pod, so the raylet will start. Maybe we can add some default liveness probe.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@chenk008 chenk008 added the enhancement New feature or request label Oct 14, 2021
@Jeffwan
Copy link
Collaborator

Jeffwan commented Oct 14, 2021

Agree. this should be improved to handle failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants