Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Autodetect GPU resources to advertise to Ray. #99

Closed
2 tasks done
DmitriGekhtman opened this issue Nov 12, 2021 · 3 comments
Closed
2 tasks done

[Feature] Autodetect GPU resources to advertise to Ray. #99

DmitriGekhtman opened this issue Nov 12, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DmitriGekhtman
Copy link
Collaborator

DmitriGekhtman commented Nov 12, 2021

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

For Ray pods configured to use GPU using one of the standard device drivers, read the number of GPUs from resource limits and automatically add that number to the --num-gpus argument of ray start, when num-gpus is not already specified.

The implementation should be straightforward and similar to existing CPU detection logic.
See the discussion in ray-project/ray#20265

Use case

This will simplify configuration for GPU workloads.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@DmitriGekhtman DmitriGekhtman added enhancement New feature or request good first issue Good for newcomers labels Nov 12, 2021
@akanso
Copy link
Collaborator

akanso commented Nov 12, 2021

We have seen cases where the users trick Ray into thinking there are more CPU --num-cpus than the actual cores allocated to the pod/container.

We also already have the raystartparams section where the users can set the num of cpus and gpus and those values will be translated into start --flags

I am fine with auto-detecting the CPU and GPU from the resource limits. One option is to add an auto-detect field that defaults to true to give the users the flexibility of not using auto-detect.

@DmitriGekhtman
Copy link
Collaborator Author

+1 for flexibility to set the ray start parameters yourself

For common/default use cases, it's better not to require redundant info.

@DmitriGekhtman
Copy link
Collaborator Author

We've covered this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants