[Autoscaler] Prefix (autoscaler) instead of (scheduler) for autoscaler events. Issue #24807 #31489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuisawesome
approved these changes
Jan 6, 2023
…r events Signed-off-by: praveeng <praveeng@anyscale.com>
gvspraveen
force-pushed
the
praveeng-24807-autoscaler
branch
from
391f4a0
to
0deafaf
Compare
|
Test failures look unrelated (docs and rllib) merging. |
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
…r events (#31489) Signed-off-by: praveeng <praveeng@anyscale.com> # Why are these changes needed? Autoscaler event logs are prefixed with (scheduler) which is misleading. This PR changes the prefix to be (autoscaler) Tested building ray locally and running an application (see attached logs). Added unit tests. # Related issue number Closes #24807
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 16, 2023
…r events (ray-project#31489) Signed-off-by: praveeng <praveeng@anyscale.com> # Why are these changes needed? Autoscaler event logs are prefixed with (scheduler) which is misleading. This PR changes the prefix to be (autoscaler) Tested building ray locally and running an application (see attached logs). Added unit tests. # Related issue number Closes ray-project#24807 Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…r events (ray-project#31489) Signed-off-by: praveeng <praveeng@anyscale.com> # Why are these changes needed? Autoscaler event logs are prefixed with (scheduler) which is misleading. This PR changes the prefix to be (autoscaler) Tested building ray locally and running an application (see attached logs). Added unit tests. # Related issue number Closes ray-project#24807 Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…r events (ray-project#31489) Signed-off-by: praveeng <praveeng@anyscale.com> # Why are these changes needed? Autoscaler event logs are prefixed with (scheduler) which is misleading. This PR changes the prefix to be (autoscaler) Tested building ray locally and running an application (see attached logs). Added unit tests. # Related issue number Closes ray-project#24807 Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Autoscaler event logs are prefixed with
(scheduler)which is misleading. This PR changes the prefix to be(autoscaler)Tested building ray locally and running an application (see attached logs). Added unit tests.
Related issue number
Closes 24807
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.