Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] nit: Correct spelling and double-dots in code example #31491

Closed
wants to merge 2 commits into from

Conversation

cwenner
Copy link

@cwenner cwenner commented Jan 6, 2023

Why are these changes needed?

These changes are minor and unimportant - they merely fix two spelling/syntax mistakes that stood out a bit in the RL documentation.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@cwenner cwenner changed the title Patch 1 nit: Correct spelling and double-dots in code example Jan 6, 2023
@cwenner cwenner changed the title nit: Correct spelling and double-dots in code example [RLlib] nit: Correct spelling and double-dots in code example Jan 6, 2023
@pcmoritz
Copy link
Contributor

@cwenner Can you merge master into this? There are some failures in the CI that I think are unrelated in the PR, it would be great to get the PR merged! Thanks for your contribution!

@pcmoritz
Copy link
Contributor

@sven1977 @gjoliver Can one of you approve / merge this?

@cwenner
Copy link
Author

cwenner commented Jan 20, 2023

Thank you, @pcmoritz. I am not authorized to merge though.

I'm not sure what is going on with the CI or whether this is normal.

Previously, only one unrelated check and the sign-off check failed. I corrected the sign off and repushed. Then when CI reran, there was this large number of failures. I am not sure how to force-rerun them until they pass.

These are just minor doc changes so I don't see how they could cause these failed checks.

@gjoliver
Copy link
Member

@cwenner thanks for the clean ups. these CI tests fail because this PR is based off an old commit.
can you do the following to rebase to the latest master? that will re-trigger and fix the tests.
First sync your forked Ray repo to the latest. Then

git checkout master
git pull --rebase
git checkout patch-1
git rebase master
git push -f origin patch-1

Tiny one: config..resources -> config.resources

Signed-off-by: Cenny <cwenner@gmail.com>
Signed-off-by: Cenny Wenner <cwenner@gmail.com>
@stale
Copy link

stale bot commented Mar 11, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Mar 11, 2023
@stale
Copy link

stale bot commented Apr 2, 2023

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants