Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.7 and build wheels. #1115

Closed
robertnishihara opened this issue Oct 12, 2017 · 19 comments
Closed

Support Python 3.7 and build wheels. #1115

robertnishihara opened this issue Oct 12, 2017 · 19 comments
Projects

Comments

@robertnishihara
Copy link
Collaborator

This also involves

@danielsuo
Copy link
Contributor

While splitting out MacOS wheels, I thought I'd give 3.7 a try (why not, I was feeling alive). The plumbing in #1205 works, but the 3.7 build fails:

  • Cython claims their latest release will build on CPython master, but I get fails for both Travis and locally using CPython 3.7a2
  • The manylinux docker we're using doesn't have cp37-cp37m yet, which makes sense, though we probably want to work with the Arrow folks to put a beta / rc 3.7 into their image over the next few months

FYI: final release is 2018-06-15

@robertnishihara
Copy link
Collaborator Author

Related to apache/arrow#1125

@xhochy
Copy link

xhochy commented Nov 10, 2017

@danielsuo @robertnishihara if we can get a docker container of any linux distro that has a built version of Python 3.7, we should be able to set up a pipeline to build Arrow & Ray. apache/arrow#1125 is probably more related to some weird in the system setup than Python 3.7 itself, sadly I cannot reproduce it with Python 3.6 on ArchLinux so I'm struggling to narrow down the problem.

@danielsuo
Copy link
Contributor

Would these work?

@xhochy
Copy link

xhochy commented Nov 15, 2017

@danielsuo they look like a good option.

@danielsuo
Copy link
Contributor

Another option: fork the manylinux image, add 3.7, and make a failed build for 3.7 not fatal.

That said, it may be cleaner to have a separate workflow for 3.7 that we simply remove / replace with updated a manylinux image when the time comes. Is that what you had in mind?

@austinnichols101
Copy link

Bump. Python 3.7 is out (27-Jun).

@robertnishihara robertnishihara changed the title Verify that Ray works with Python 3.7. Support Python 3.7 and build wheels. Jul 9, 2018
@rubik
Copy link

rubik commented Aug 15, 2018

Is there any new release planned now that Python 3.7 is in use in many linux distributions?

@robertnishihara
Copy link
Collaborator Author

Yeah, we should do this for the next release (0.6).

@timonbimon
Copy link
Contributor

do you already have a rough idea when 0.6 will be released? :)

@robertnishihara robertnishihara added this to To do in 0.6 release Sep 1, 2018
@robertnishihara
Copy link
Collaborator Author

@timonbimon our more aggressive timeline is roughly 1 month.

@timonbimon
Copy link
Contributor

awesome, thanks for the amazing work :)

@sadatnfs
Copy link

Looks like Miniconda's latest (default) version download 3.7 now. I feel a lot of installs breaking :(

@pcmoritz
Copy link
Contributor

Good point, thanks for bringing that up. It's in the works here: #2546, we can prioritize merging it soon.

@robertnishihara robertnishihara moved this from To do to In progress in 0.6 release Oct 18, 2018
@robertnishihara robertnishihara moved this from In progress to Done in 0.6 release Oct 19, 2018
@robertnishihara
Copy link
Collaborator Author

Fixed by #2546.

@robertnishihara
Copy link
Collaborator Author

The wheels still haven't been uploaded to PyPI, but you can get them by following the instructions at https://ray.readthedocs.io/en/latest/installation.html#trying-the-latest-version-of-ray and modifying the URL to use 3.7.

@manugarri
Copy link

any updates on this? Would like to be able to use ray on a windows machine. Maybe there is a conda binary available?

@robertnishihara
Copy link
Collaborator Author

@manugarri for Windows, the relevant issue is #631. We're working on it, but it isn't ready yet.

@manugarri
Copy link

got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.6 release
  
Done
Development

No branches or pull requests

9 participants