Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoscaler][aws] Refactor _check_ami to work with available node types #15348

Closed
2 tasks
DmitriGekhtman opened this issue Apr 16, 2021 · 1 comment · Fixed by #15584
Closed
2 tasks

[autoscaler][aws] Refactor _check_ami to work with available node types #15348

DmitriGekhtman opened this issue Apr 16, 2021 · 1 comment · Fixed by #15584
Assignees
Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical
Milestone

Comments

@DmitriGekhtman
Copy link
Contributor

What is the problem?

Ray version and other system information (Python version, TensorFlow version, OS):

Subset of
#15108

This makes ray up aws/example-full.yaml fail with AWS accounts based in certain (most?) regions.
See this discussion:
https://discuss.ray.io/t/cannot-copy-ami-ami-0a2363a9cff180a64/1720

Reproduction (REQUIRED)

Please provide a short code snippet (less than 50 lines if possible) that can be copy-pasted to reproduce the issue. The snippet should have no external library dependencies (i.e., use fake or mock data / environments):

If the code snippet cannot be run by itself, the issue will be closed with "needs-repro-script".

  • I have verified my script runs in a clean environment and reproduces the issue.
  • I have verified the issue also occurs with the latest wheels.
@DmitriGekhtman DmitriGekhtman added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Apr 16, 2021
@DmitriGekhtman
Copy link
Contributor Author

Actually, maybe part of the the right fix here would be to change ImageId in our example configs to latest_dlami which is autofilled to the right thing.

@richardliaw richardliaw added this to the Serverless Autoscaling milestone Apr 21, 2021
@richardliaw richardliaw added P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants