Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] IMPALA (any tf algo using entropy coeff) slowdown observed #15936

Closed
2 tasks done
sven1977 opened this issue May 20, 2021 · 0 comments · Fixed by #15937
Closed
2 tasks done

[RLlib] IMPALA (any tf algo using entropy coeff) slowdown observed #15936

sven1977 opened this issue May 20, 2021 · 0 comments · Fixed by #15937
Assignees
Labels
bug Something that is supposed to be working; but isn't P0 Issue that must be fixed in short order release-blocker P0 Issue that blocks the release rllib RLlib related issues

Comments

@sven1977
Copy link
Contributor

sven1977 commented May 20, 2021

Since ray 1.2, IMPALA (and any other tf algorithm that uses entropy_coeff) has slowed down due to a bug.

  • The bug is caused by a tf-(static graph)-op being added to the graph each time we call on_global_var_update (defined inside the EntropyCoeffSchedule (tf) mixin class).

To reproduce:

rllib train -f rllib/tuned_examples/impala/pong-impala-fast.yaml

Runs much slower than in ray<=1.1.

What is the problem?

Ray version and other system information (Python version, TensorFlow version, OS):

Reproduction (REQUIRED)

Please provide a short code snippet (less than 50 lines if possible) that can be copy-pasted to reproduce the issue. The snippet should have no external library dependencies (i.e., use fake or mock data / environments):

If the code snippet cannot be run by itself, the issue will be closed with "needs-repro-script".

  • I have verified my script runs in a clean environment and reproduces the issue.
  • I have verified the issue also occurs with the latest wheels.
@sven1977 sven1977 added bug Something that is supposed to be working; but isn't release-blocker P0 Issue that blocks the release P0 Issue that must be fixed in short order rllib RLlib related issues labels May 20, 2021
@sven1977 sven1977 self-assigned this May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P0 Issue that must be fixed in short order release-blocker P0 Issue that blocks the release rllib RLlib related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant