Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] xgboost_ray fault tolerance tests don't pass with xgboost v1.5.0 #20327

Closed
amogkam opened this issue Nov 13, 2021 · 5 comments
Closed
Assignees
Labels
stale The issue is stale. It will be closed within 7 days unless there are further conversation

Comments

@amogkam
Copy link
Contributor

amogkam commented Nov 13, 2021

The ft_small_elastic and ft_small_nonelastic tests are passing with the ray-ml:pinned-nightly base image, but are failing on the ray:nightly image.

We should fix the Docker image so that xgboost_ray works out of the box with the image.

@amogkam amogkam added P0 Issues that should be fixed in short order release-blocker P0 Issue that blocks the release labels Nov 13, 2021
@amogkam
Copy link
Contributor Author

amogkam commented Nov 13, 2021

Looks like this is due to an issue with xgboost-ray compatibility with newer versions of xgboost (1.5.0): ray-project/xgboost_ray#176.

So the issue is not related to Ray or the Ray Docker image. Will remove this as a release blocker.

@amogkam
Copy link
Contributor Author

amogkam commented Nov 13, 2021

Once ray-project/xgboost_ray#176 is fixed, will upgrade back to the ray:nightly image.

@amogkam amogkam removed release-blocker P0 Issue that blocks the release P0 Issues that should be fixed in short order labels Nov 13, 2021
@amogkam amogkam changed the title [Release] xgboost_ray fault tolerance tests don't pass on nightly Ray docker image [Release] xgboost_ray fault tolerance tests don't pass with xgboost v1.5.0 Nov 13, 2021
@krfricke
Copy link
Contributor

See also dmlc/xgboost#7436

I'm going to fix this this week.

@stale
Copy link

stale bot commented Mar 16, 2022

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

  • If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
  • If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Mar 16, 2022
@stale
Copy link

stale bot commented Apr 7, 2022

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

No branches or pull requests

2 participants