Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] unpin libffi=3.3 once conda resolves the dependency issue #33299

Closed
scv119 opened this issue Mar 14, 2023 · 4 comments · May be fixed by #37088
Closed

[core] unpin libffi=3.3 once conda resolves the dependency issue #33299

scv119 opened this issue Mar 14, 2023 · 4 comments · May be fixed by #37088
Labels
core Issues that should be addressed in Ray Core core-fundamentals core-tech-debt dependencies Pull requests that update a dependency file enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks size:small stability

Comments

@scv119
Copy link
Contributor

scv119 commented Mar 14, 2023 •
edited

What happened + What you expected to happen

as title, we should unpin it once the root cause is resolved. #33294

blocked by conda/conda#12287 (comment)

Versions / Dependencies

latest

Reproduction script

latest

Issue Severity

Medium: It is a significant difficulty but I can work around it.
@scv119 scv119 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core Ray 2.5 P1 Issue that should be fixed within a few weeks labels Mar 14, 2023
@richardliaw richardliaw removed the triage Needs triage (eg: priority, bug/not-bug, and owning component) label Mar 16, 2023
@rkooo567 rkooo567 added the tech-debt The issue that's due to tech debt label Mar 24, 2023
@scv119 scv119 added Ray 2.6 and removed Ray 2.5 labels Apr 19, 2023
@scv119
Copy link
Contributor Author

scv119 commented Apr 19, 2023

nothing we can do here. the root cause seems not fixed yet.

@rkooo567 rkooo567 added core-tech-debt size:small and removed tech-debt The issue that's due to tech debt labels Jun 2, 2023
@can-anyscale
Copy link
Collaborator

@rickyyx this issue will probably block docker build for python 3.11 (https://github.com/ray-project/ray/blob/master/docker/base-deps/Dockerfile#L60), libffi=3.3 is not compatible with python 3.11

@rickyyx
Copy link
Contributor

rickyyx commented Jun 14, 2023 •
edited

Ah, this is sad...

Maybe could we figure out why we need libffi in the first place?

@rickyyx rickyyx mentioned this issue Jun 20, 2023
Merged
3 tasks
@rkooo567 rkooo567 added P0 Issues that should be fixed in short order and removed P1 Issue that should be fixed within a few weeks labels Jun 28, 2023
@scv119 scv119 added Ray 2.7 and removed Ray 2.6 labels Jul 5, 2023
@scv119 scv119 linked a pull request Jul 5, 2023 that will close this issue
revert fix: pin libffi=3.3 for base-deps #33294 #37088
Open
8 tasks
@rkooo567 rkooo567 added P1 Issue that should be fixed within a few weeks and removed P0 Issues that should be fixed in short order labels Jul 17, 2023
@rkooo567 rkooo567 added the dependencies Pull requests that update a dependency file label Jul 24, 2023
@rkooo567 rkooo567 added ray 2.8 and removed Ray 2.7 labels Aug 2, 2023
@anyscalesam anyscalesam added enhancement Request for new feature and/or capability and removed bug Something that is supposed to be working; but isn't labels Apr 15, 2024
@jjyao
Copy link
Contributor

jjyao commented Apr 15, 2024

Fixed by #41339

@jjyao jjyao closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues that should be addressed in Ray Core core-fundamentals core-tech-debt dependencies Pull requests that update a dependency file enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks size:small stability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revert fix: pin libffi=3.3 for base-deps #33294 scv119/ray
7 participants
@scv119 @jjyao @richardliaw @rickyyx @rkooo567 @anyscalesam @can-anyscale