Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] If RLModule is enabled by default user should get warnings if they are using old stack related components. #37085

Closed
kouroshHakha opened this issue Jul 5, 2023 · 0 comments
Closed

[RLlib] If RLModule is enabled by default user should get warnings if they are using old stack related components. #37085

kouroshHakha opened this issue Jul 5, 2023 · 0 comments
Assignees
@ArturNiederfahrenhorst
Labels
docs An issue or change related to documentation P0 Issue that must be fixed in short order rllib RLlib related issues rllib-newstack

Comments

@kouroshHakha
Copy link
Contributor

What happened + What you expected to happen

If RLModule is enabled by default users should get warnings if they are using old stack related components, e.g. ModelV2 or custom policy loss, etc.

This may add more color to the issue:

https://discuss.ray.io/t/how-to-define-a-graph-type-observation-space-and-use-torch-geometric/11221/6

Versions / Dependencies

NA

Reproduction script

Look at the linked discourse.

Issue Severity

Low: It annoys or frustrates me.
@kouroshHakha kouroshHakha added P0 Issue that must be fixed in short order rllib RLlib related issues docs An issue or change related to documentation rllib-newstack labels Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArturNiederfahrenhorst ArturNiederfahrenhorst

Labels
docs An issue or change related to documentation P0 Issue that must be fixed in short order rllib RLlib related issues rllib-newstack
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArturNiederfahrenhorst @kouroshHakha