Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Improve block size selection when reading large jsonl data chunks #41196

Closed
scottjlee opened this issue Nov 16, 2023 · 0 comments · Fixed by #42357
Closed

[Data] Improve block size selection when reading large jsonl data chunks #41196

scottjlee opened this issue Nov 16, 2023 · 0 comments · Fixed by #42357
Assignees
Labels
data Ray Data-related issues enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks ray 2.10 size:small

Comments

@scottjlee
Copy link
Contributor

Description

As a followup to #40533, add logic to gracefully handle cases where the block size configured in Arrow's JSON loader is too small.

Hugging Face has an implementation where they handle this dynamically, we could do something similar by adding an improved default value and fallback logic to increase the block size to a sufficient value: https://github.com/huggingface/datasets/blob/d122b3ddc67705cc2b622bcbd79de9ff943a5742/src/datasets/packaged_modules/json/json.py#L119

Related issues:

Use case

No response

@scottjlee scottjlee added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) P1 Issue that should be fixed within a few weeks data Ray Data-related issues ray 2.10 and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 16, 2023
@c21 c21 assigned scottjlee and unassigned scottjlee Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Ray Data-related issues enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks ray 2.10 size:small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants