Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray] Pyarmor compatibility #8365

Open
2 tasks done
PidgeyBE opened this issue May 8, 2020 · 1 comment
Open
2 tasks done

[ray] Pyarmor compatibility #8365

PidgeyBE opened this issue May 8, 2020 · 1 comment
Labels
bug Something that is supposed to be working; but isn't P3 Issue moderate in impact or severity

Comments

@PidgeyBE
Copy link
Contributor

PidgeyBE commented May 8, 2020

What is the problem?

When trying to execute pyarmor obfuscated scripts in ray, we are facing issues with the python dis package. We are using Actors. Depending on how Actors are instantiated, the error occurs at a different place:

To fix the issue with the decorator, I think we need a fix at Pyarmor side. That's why I filed an issue there: dashingsoft/pyarmor#231
But even without a fix at pyarmor side, which might be not feasible, we can run obfuscated code in ray if we don't use the decorator and the function_manager is patched, so it doesn't use dis anymore. Is this feasible?

Ray version and other system information (Python version, TensorFlow version, OS):

  • ray==0.8.3
  • pyarmor==6.1.0
  • Ubuntu 16

Reproduction (REQUIRED)

see dashingsoft/pyarmor#231. The second example is the one I'd love to see fixed in ray!

If we cannot run your script, we cannot fix your issue.

  • I have verified my script runs in a clean environment and reproduces the issue.
  • I have verified the issue also occurs with the latest wheels.

Best regards, Pieterjan

@PidgeyBE PidgeyBE added the bug Something that is supposed to be working; but isn't label May 8, 2020
@rkooo567 rkooo567 added the triage Needs triage (eg: priority, bug/not-bug, and owning component) label May 27, 2020
@PidgeyBE
Copy link
Contributor Author

Meanwhile the issue will be avoidable in one of the upcoming pyarmor releases, by making sure opcodes are not changed during the obfuscation process. It's less secure, but it works.
So discarding the use of the dis package would still be very helpful!

@ericl ericl added P3 Issue moderate in impact or severity and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P3 Issue moderate in impact or severity
Projects
None yet
Development

No branches or pull requests

3 participants