silent_catch: Make silent_catch a special case of catch #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| def catch(_func=None, *, exception=None, handler=None): | ||
| def catch(_func=None, *, exception=None, handler=None, silent=False): |
There was a problem hiding this comment.
Function catch has 5 arguments (exceeds 4 allowed). Consider refactoring.
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 93.16% 93.73% +0.56%
==========================================
Files 9 9
Lines 395 383 -12
==========================================
- Hits 368 359 -9
+ Misses 27 24 -3
Continue to review full report at Codecov.
|
|
Code Climate has analyzed commit dc7d9a6 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
rayanht
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reuse code!
Fixes #23
Test plan
Unit tests remain passing.