Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1Password] Better handle when 1Password CLI is updated via Homebrew #11434

Closed
chrismessina opened this issue Mar 22, 2024 · 4 comments
Closed
Labels
bug Something isn't working extension Issues related to one of the extensions in the Store extension: 1password Issues related to the 1password extension

Comments

@chrismessina
Copy link
Contributor

Extension

https://www.raycast.com/khasbilegt/1password

Description

I'm running the Beta of 1Password (1Password for Mac 8.10.30 (81030001)).

Recently the 1Password CLI updated from v2.24.0 to v2.26.0, including changing the location on disk from:

/opt/homebrew/Caskroom/1password-cli/2.24.0/op

to:

/opt/homebrew/Caskroom/1password-cli/2.26.0/op

I'm not sure if this happened when I ran brew upgrade or when I updated 1Password (I presume the latter) but it caused the 1Password Raycast Extension to silently fail.

Given that 1Password's CLI docs recommend using Homebrew as the default installation method, it would probably be good for the 1Password Raycast extension to better handle this situation.

Steps To Reproduce

  1. Update the 1Password CLI binary via Homebrew (which will update the binary's path)
  2. The Raycast extension, unless its configuration is updated manually, will fallback to showing the README, which tells the user how to install the CLI.

Current Behaviour

  1. Update the 1Password CLI binary via Homebrew (e.g. from v2.24.0 to v2.26.0)
  2. Launch Raycast and activate the 1P extension
  3. See Extension README

Expected Behaviour

  1. Update the 1Password CLI binary via Homebrew (e.g. from v2.24.0 to v2.26.0)
  2. Launch Raycast and activate the 1P extension
  3. Raycast 1Password Extension should automatically update the path for the CLI if it's been changed.
@chrismessina chrismessina added bug Something isn't working extension Issues related to one of the extensions in the Store labels Mar 22, 2024
@raycastbot raycastbot added the extension: 1password Issues related to the 1password extension label Mar 22, 2024
@raycastbot
Copy link
Collaborator

Thank you for opening this issue!

🔔 @khasbilegt @thomaspaulmann @dteare @pernielsentikaer @cb372 @Davidwalser @henrik-dmg @justspacedog @kjeldahl @superwhys you might want to have a look.

💡 Author and Contributors commands

The author and contributors of khasbilegt/1password can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopen the issue.

@Luk4h
Copy link
Contributor

Luk4h commented Apr 8, 2024

You have an interesting location for the program, when you run where op on your terminal it also points to /opt/homebrew/Caskroom/1password-cli/2.26.0/op? Mine even after updating keeps on /opt/homebrew/bin.

@chrismessina
Copy link
Contributor Author

When I run where op I get:

/opt/homebrew/bin/op

@Luk4h
Copy link
Contributor

Luk4h commented Apr 8, 2024

You should write that text in the 1Password CLI property within the extension config.

In the latest release, it automatically checks that path to see if it is installed using Homebrew. The disk location is different from the command location.

@raycastbot close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extension Issues related to one of the extensions in the Store extension: 1password Issues related to the 1password extension
Projects
None yet
Development

No branches or pull requests

3 participants