Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-functional Update Resource API #161

Open
mabdh opened this issue Aug 18, 2022 · 1 comment
Open

Fix non-functional Update Resource API #161

mabdh opened this issue Aug 18, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@mabdh
Copy link
Member

mabdh commented Aug 18, 2022

Is your feature request related to a problem? Please describe.
Shield's update resource API is just forwarding what user put and stores it in the DB. However this behaviour is not valid. The behaviour of Update API should be similar with Create resource API.
In Update Resource API, we also need to remove and re-add org/owner/team to the resource and not just simply update the data in DB. Calling our current update resource API will leave our DB and AuthzDB in inconsistent state.

Describe the solution you'd like
Fix the behaviour of Update resource DB or if it is not usable, better to remove it.

@mabdh mabdh added the bug Something isn't working label Aug 18, 2022
@ravisuhag
Copy link
Member

@kushsharma is this still applicable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 2024
Development

No branches or pull requests

2 participants