Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kafka library to avoid enabling cgo #168

Closed
StewartJingga opened this issue Aug 18, 2021 · 0 comments · Fixed by #167
Closed

update kafka library to avoid enabling cgo #168

StewartJingga opened this issue Aug 18, 2021 · 0 comments · Fixed by #167
Labels
core Core framework feature enhancement New feature or request

Comments

@StewartJingga
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Meteor requires CGO_ENABLED to be set to true for cross building due to dependency with https://github.com/confluentinc/confluent-kafka-go. Enabling CGO will require the machine to have all required os tools or else build will fail.

Describe the solution you'd like
Update kafka library to those who do not use C client. e.g. https://github.com/segmentio/kafka-go

Describe alternatives you've considered
Create a docker image with all the required os toolchains.
@StewartJingga StewartJingga linked a pull request Aug 18, 2021 that will close this issue
feat(kafka): change kafka library to avoid enabling cgo #167
Merged
@ravisuhag ravisuhag added enhancement New feature or request core Core framework feature labels Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Core framework feature enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(kafka): change kafka library to avoid enabling cgo raystack/meteor
2 participants
@ravisuhag @StewartJingga