Skip to content
This repository has been archived by the owner on Nov 8, 2020. It is now read-only.

Assemblies should target netstandard2.2 for greater compatibility #44

Closed
ElanHasson opened this issue Jul 16, 2020 · 4 comments · Fixed by #45
Closed

Assemblies should target netstandard2.2 for greater compatibility #44

ElanHasson opened this issue Jul 16, 2020 · 4 comments · Fixed by #45
Assignees

Comments

@ElanHasson
Copy link
Collaborator

<TargetFrameworks>netcoreapp2.2;netcoreapp3.1</TargetFrameworks>

The libraries should target netstandard2.0 to increase application target runtimes.

@newbe36524
Copy link

Cause there are some class include in netstandard2.1/etcoreapp2.2/netcoreapp3.1 but not netstandard2.0 ,Such as Memory or somthing for performance.

@ElanHasson
Copy link
Collaborator Author

https://github.com/RayTale/Ray/blob/master/Test/Directory.Build.props#L3

Why dual targeting here? are people using 2.1 and 3.1?

@ElanHasson
Copy link
Collaborator Author

ElanHasson commented Jul 17, 2020

I just validated netstandard2.1 works fine.

netstandard2.0 doesn't have span and a few other things.

If we can drop netcoreapp2.2 we can use netstandard2.1 .

Let me know if you'd like a pull request for this.

@ElanHasson ElanHasson changed the title Assemblies should target netstandard2.0 Assemblies should target netstandard2.2 for greater compatibility Jul 17, 2020
@ElanHasson
Copy link
Collaborator Author

Feel free to reject the PR if you need to keep netcoreapp2.2. That is the only reason we can't move forward.

@ElanHasson ElanHasson added this to Done in Project Cleanup Jul 18, 2020
@ElanHasson ElanHasson self-assigned this Jul 18, 2020
@ElanHasson ElanHasson linked a pull request Jul 18, 2020 that will close this issue
@ElanHasson ElanHasson added this to the Project Cleanup milestone Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants