Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hold] Moves the countdown method to main actor #28

Closed
wants to merge 1 commit into from

Conversation

icanzilb
Copy link
Member

In one part of chapter 4 the countdown uses a Timer and in iOS16 sometimes the code ends up off the main thread and timer doesn't work, this PR annotates the method on the main actor

@jrturton
Copy link
Contributor

I think the general advice is that an observable object should be annotated as main actor at the class level, there are now multiple methods in here that are main actor annotated, should we switch it over?

@icanzilb
Copy link
Member Author

@jrturton this might make sense indeed, I'm just thinking that we'll need to likely change text & code across 3 chapters to spread these changes. You think we should do that or?

@jrturton
Copy link
Contributor

If that's the way we're supposed to describe these objects, then yes - @freak4pc do you have an opinion?

@icanzilb icanzilb changed the title Moves the countdown method to main actor [hold] Moves the countdown method to main actor Nov 15, 2022
@freak4pc
Copy link
Member

freak4pc commented Feb 3, 2023

Marin mentioned you resolved this, closing :)

@freak4pc freak4pc closed this Feb 3, 2023
@freak4pc freak4pc deleted the marin_todorov/blabber-timer-fix branch February 3, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants