Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global: Light Mode Style Updates #511

Closed
luke-freeman opened this issue Nov 2, 2020 · 9 comments · Fixed by #616
Closed

Global: Light Mode Style Updates #511

luke-freeman opened this issue Nov 2, 2020 · 9 comments · Fixed by #616
Assignees
Labels

Comments

@luke-freeman
Copy link

luke-freeman commented Nov 2, 2020

Update the light mode version of the app to match the website.

  • Remove all instances of the grey background
  • Add drop shadow to cards and search box
  • Adjust drop shadow of the bottom navigation

It should look similar to this:

Library (Light Mode)

You can find full designs for light mode here

https://www.figma.com/file/LCwFKA0AmG9EcOQPBamGAb/Emitron-iOS?node-id=0%3A2533

@bladebunny
Copy link
Contributor

I'm willing to work on this but can't access the Figma file. I assume it has the specific styles (e.g. size and colors) I would need.

@sammyd
Copy link
Collaborator

sammyd commented Mar 22, 2021

@luke-freeman could you take a look at giving @bladebunny access to the Figma file please, and providing any additional direction.

@bladebunny when working on UI tickets, please attach some screenshots of the end result to the PR and ask both @0xTim and @luke-freeman to review to make sure that the designs match what Luke envisaged.

Thanks so much for offering to take this on!

@bladebunny
Copy link
Contributor

@sammyd Will do. Will add some screenshots in a few.

@luke-freeman
Copy link
Author

@bladebunny @sammyd

Lost the design when converting from Sketch to Figma. I'll create a new one soon

@sammyd
Copy link
Collaborator

sammyd commented Aug 2, 2021

🔔 @luke-freeman

@luke-freeman
Copy link
Author

@VegetarianZombie

I've set a task to create the designs for this. Hopefull in the next 2 weeks

@luke-freeman
Copy link
Author

@VegetarianZombie

This is now available https://www.figma.com/file/L2sd1y9u715iuKxotJ0GGt/Emitron-iOS?node-id=0%3A2282

let me knwo if you need any additional designs/screens.

The main change from the old design is the removal of the grey background and adding a drop shadow to the UI elements

@VegetarianZombie VegetarianZombie self-assigned this Aug 27, 2021
@VegetarianZombie
Copy link
Contributor

@VegetarianZombie Okay, I'm working on implementing this.

@VegetarianZombie VegetarianZombie linked a pull request Oct 29, 2021 that will close this issue
@VegetarianZombie
Copy link
Contributor

PR Submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants