Settings: Move settings to it's own tab

[luke-freeman]

Settings currently lives under 'My Tutorials'. Move Settings to it's own top level tab

Expected behavior

Settings has it's own tab

Actual behavior

Settings can only be accessed from My Tutorials

[byaruhaf]

@luke-freeman, I'm trying to implement this enhancement wanted your advice on three items

1. Move Settings to it's own top level tab, does that mean that we remove Settings from My Tutorials
2. If 1 above is true then X in the setting screen is no longer needed since switching away from settings will done on the tab bar.
3. is there a Design for Settings with a tab bar the only one I see in Figma is setting with out a tab bar.

Image	GIF

[luke-freeman]

@byaruhaf

• That's right it should no longer exist on 'My Tutorials'
• There's no design but can you set it up as if it wasn't a modal and instead a typical view? (So no x)

[luke-freeman]

@byaruhaf @0xTim

Functionally this works great!

But the new settings icon is misaligned. Can you align it to the top with the other icons?

[byaruhaf]

@luke-freeman I have updated the setting icon is this ok.

[luke-freeman]

@byaruhaf

Now the settings icon is too big. It should be the same size as the others and sit comfortably between the lines in the screenshot above

[byaruhaf]

@luke-freeman I have shrunk the icon, please check two options below:

Option 1

Option 2

[luke-freeman]

@byaruhaf

I think the settings icon needs to be 1-2pt/px bigger.

Also I see some new issues:

• Is it just me or the settings icon appears blurry now?
• Also the settings icon is using a different grey to the other icons

[bladebunny]

PR submitted to match existing icons.
#559

[byaruhaf]

Hi @luke-freeman

Have you taken a look at the settings icons in PR #561? They look as shown below:
if this is ok then we can close this issue.
if it's not ok can you design the setting icon the same as the library icon & library icon for this use case

[bladebunny]

For some reason this isn't the most recent. Here's what at least the PR for the settings icon itself looks like. (Lines added in Dark Mode). I can switch out the image if need be. The issue was the first set of icons use actual images whereas the settings icon was using a font image (systemName) -- where the final size and internal padding vary. I would argue where precision counts you probably don't want to use the system font images. I would prefer svg images or png's.

[byaruhaf]

This looks good, lets wait for @luke-freeman comment

[luke-freeman]

@byaruhaf @bladebunny

Looks excellent thanks!