fix: updated and added comments on contracts #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamAg19
previously approved these changes
Apr 11, 2022
GauravJain9
changed the title
SamAg19
requested changes
Apr 13, 2022
contracts/Core/CollectionManager.sol
Outdated
| @@ -372,6 +372,9 @@ contract CollectionManager is Initializable, CollectionStorage, StateManager, Co | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * @dev updates the collectionIdToLeafIdRegistryOfLastEpoch everytime a block is being confirmed | |||
There was a problem hiding this comment.
not everytime but whenever a collection status is changed/new collection is created
SamAg19
approved these changes
Apr 14, 2022
SamAg19
added a commit
that referenced
this pull request
Jul 29, 2022
* fix: updated and added comments on contracts (#789) * fix: updated and added comments in stakeManager and interface * fix: updated and added comments on contracts * fix: updated comment in collectionManager contract * feat: made getstate and getepoch functions public (#795) * feat: made getstate and getepoch function public * fix: linting errors * fix: fixed naming issue in RandomNoManager * feat: hardhat-deploy (#797) * feat(hardhatdeploy): poc hardhat-deploy integrate hardhat-deploy plugin to deploy test contract * feat(hardhat-deploy): integrate hardhat-deploy plugin deploy all Razor contracts using hardhat-deploy, update deploy.sh script * fix(hardhat-deploy): integrate hardhat-deploy plugin hotfix remove test contract * fix(hardhat-deploy): integrate hardhat-deploy plugin hotfix remove unnecessary changes * fix(hardhat-deploy): integrate hardhat-deploy plugin hotfix remove unnecessary changes * fix(hardhat-deploy): fix current post deployment wait for contract deployment file to updated * fix(hardhat-deploy): migrate contracts setup create shared folder for contracts initialisation and grant role * feat(hardhat-deploy): post deployment test add post deployment script test, 1 staker to vote for 1 epoch * feat(hardhat-deploy): clean up hotfix * fix: lint fix and yarn.lock * feat(hardhat-deploy): add deployment fixtures for tests * fix(hardhat-deploy): fix circleci errors * feat(hardhat-deploy): remove postdeployment test and deployment fixtures. Release hardhat-deploy * feat(hardhat-deploy): use common deploy func, code modularisation * feat(hardhat-deploy): circleci hotfix * fix: clean up functions,rename deploy_all * fix: postdeployment setup code clean up and fixes for failing init contract + same contract instance * fix: update grant role to promise * fix: add deploy readme * fix: move to root folder * fix: update content * chore: removal of hardhat-truffle (#810) * chore: removal of hardhat-truffle * fix: linting fixes * feat: added skale-v2 support in hardhat config (#813) * feat: added skale-v2 support in hardhat config * fix: resolved linting in hardhat config * feat: occurrence support (#793) * feat: occurrence support * fix: slither issues * fix: slither issues part 2 * fix: slither issues part 3 * test: adding positive testcases to bond manager * test: fixing tests * test: refactored bondManager tests and added tests to governance * feat: adding more governance params and test cases * fix: linting fixes * fix: solidity linting fixes * test: add negative test cases * fix: linting fixes * fix: merge fixes * fix: bond manager fixes * fix: slither fixes * fix: deployment scripted added for bond manager and v1.0.1 incentnet phase 2 changes incorporated * fix: post deployment script fix * fix: post deployment create jobs fix * fix: post deployment create collection fix * fix: linting fixes * build(deps): bump semver-regex from 3.1.3 to 3.1.4 (#817) Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/sindresorhus/semver-regex/releases) - [Commits](https://github.com/sindresorhus/semver-regex/commits/v3.1.4) --- updated-dependencies: - dependency-name: semver-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump semantic-release from 19.0.2 to 19.0.3 (#826) Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 19.0.2 to 19.0.3. - [Release notes](https://github.com/semantic-release/semantic-release/releases) - [Commits](semantic-release/semantic-release@v19.0.2...v19.0.3) --- updated-dependencies: - dependency-name: semantic-release dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: sortedValues datatype fix (#850) * fix: Post deployment testing + Fixing Governance and ContractM Initialisation (#840) * test: use post deployment helpers in postdeployment test * chore: remove tmp * chore: add post deployment tmp json to gitignore * fix: update post deployment to support databonds * fix: fix collectionM and gov contract initialisation, clean up post deployment script * chore: clean up * fix: increase network timeout (#845) * fix: increase network timeout * chore: update timeout to 5 min * build(deps): bump npm from 8.9.0 to 8.12.1 (#827) Bumps [npm](https://github.com/npm/cli) from 8.9.0 to 8.12.1. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v8.9.0...v8.12.1) --- updated-dependencies: - dependency-name: npm dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Skanda Bhat <bhat.skanda.m@gmail.com> Co-authored-by: Gaurav Jain <65170724+GauravJain9@users.noreply.github.com> Co-authored-by: Yohan Nelson <yohan.nelson@gmail.com> Co-authored-by: Shrikant upadhyay <shrikant1997upadhyay@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Raj Kharvar <rajkharvar1808@gmail.com>
SkandaBhat
added a commit
that referenced
this pull request
Sep 13, 2022
* fix: updated and added comments on contracts (#789) * fix: updated and added comments in stakeManager and interface * fix: updated and added comments on contracts * fix: updated comment in collectionManager contract * feat: made getstate and getepoch functions public (#795) * feat: made getstate and getepoch function public * fix: linting errors * fix: fixed naming issue in RandomNoManager * feat: hardhat-deploy (#797) * feat(hardhatdeploy): poc hardhat-deploy integrate hardhat-deploy plugin to deploy test contract * feat(hardhat-deploy): integrate hardhat-deploy plugin deploy all Razor contracts using hardhat-deploy, update deploy.sh script * fix(hardhat-deploy): integrate hardhat-deploy plugin hotfix remove test contract * fix(hardhat-deploy): integrate hardhat-deploy plugin hotfix remove unnecessary changes * fix(hardhat-deploy): integrate hardhat-deploy plugin hotfix remove unnecessary changes * fix(hardhat-deploy): fix current post deployment wait for contract deployment file to updated * fix(hardhat-deploy): migrate contracts setup create shared folder for contracts initialisation and grant role * feat(hardhat-deploy): post deployment test add post deployment script test, 1 staker to vote for 1 epoch * feat(hardhat-deploy): clean up hotfix * fix: lint fix and yarn.lock * feat(hardhat-deploy): add deployment fixtures for tests * fix(hardhat-deploy): fix circleci errors * feat(hardhat-deploy): remove postdeployment test and deployment fixtures. Release hardhat-deploy * feat(hardhat-deploy): use common deploy func, code modularisation * feat(hardhat-deploy): circleci hotfix * fix: clean up functions,rename deploy_all * fix: postdeployment setup code clean up and fixes for failing init contract + same contract instance * fix: update grant role to promise * fix: add deploy readme * fix: move to root folder * fix: update content * chore: removal of hardhat-truffle (#810) * chore: removal of hardhat-truffle * fix: linting fixes * feat: added skale-v2 support in hardhat config (#813) * feat: added skale-v2 support in hardhat config * fix: resolved linting in hardhat config * feat: occurrence support (#793) * feat: occurrence support * fix: slither issues * fix: slither issues part 2 * fix: slither issues part 3 * test: adding positive testcases to bond manager * test: fixing tests * test: refactored bondManager tests and added tests to governance * feat: adding more governance params and test cases * fix: linting fixes * fix: solidity linting fixes * test: add negative test cases * fix: linting fixes * fix: merge fixes * fix: bond manager fixes * fix: slither fixes * fix: deployment scripted added for bond manager and v1.0.1 incentnet phase 2 changes incorporated * fix: post deployment script fix * fix: post deployment create jobs fix * fix: post deployment create collection fix * fix: linting fixes * build(deps): bump semver-regex from 3.1.3 to 3.1.4 (#817) Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/sindresorhus/semver-regex/releases) - [Commits](https://github.com/sindresorhus/semver-regex/commits/v3.1.4) --- updated-dependencies: - dependency-name: semver-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump semantic-release from 19.0.2 to 19.0.3 (#826) Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 19.0.2 to 19.0.3. - [Release notes](https://github.com/semantic-release/semantic-release/releases) - [Commits](semantic-release/semantic-release@v19.0.2...v19.0.3) --- updated-dependencies: - dependency-name: semantic-release dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: sortedValues datatype fix (#850) * fix: Post deployment testing + Fixing Governance and ContractM Initialisation (#840) * test: use post deployment helpers in postdeployment test * chore: remove tmp * chore: add post deployment tmp json to gitignore * fix: update post deployment to support databonds * fix: fix collectionM and gov contract initialisation, clean up post deployment script * chore: clean up * fix: increase network timeout (#845) * fix: increase network timeout * chore: update timeout to 5 min * build(deps): bump npm from 8.9.0 to 8.12.1 (#827) Bumps [npm](https://github.com/npm/cli) from 8.9.0 to 8.12.1. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v8.9.0...v8.12.1) --- updated-dependencies: - dependency-name: npm dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: code coverage fix * chore: removed unnecessary changes Co-authored-by: Skanda Bhat <bhat.skanda.m@gmail.com> Co-authored-by: Gaurav Jain <65170724+GauravJain9@users.noreply.github.com> Co-authored-by: Yohan Nelson <yohan.nelson@gmail.com> Co-authored-by: Shrikant upadhyay <shrikant1997upadhyay@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Raj Kharvar <rajkharvar1808@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #788
Fixes #791