Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reinstall npm packages when checking out to master circleci #847

Merged
merged 5 commits into from
Jun 21, 2022

Conversation

yohanelly95
Copy link
Member

@yohanelly95 yohanelly95 commented Jun 17, 2022

  • Master has hardhat-deploy integrated and the current branch (v1-audit-feedback) does not.

  • Steps causing the issue: We install the current branches npm packages, run gasCompare, then checkout to master and run gasCompare again. We now need to reinstall npm packages when checking out to master to make sure missing modules are installed.

@yohanelly95 yohanelly95 marked this pull request as ready for review June 17, 2022 05:18
@yohanelly95 yohanelly95 self-assigned this Jun 17, 2022
@yohanelly95 yohanelly95 changed the title fix: reinstall npm packages when checking out to master fix: reinstall npm packages when checking out to master circleci Jun 17, 2022
@SamAg19 SamAg19 merged commit ea616c3 into razor-network:v1-audit-feedback Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants