Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to treat 0 and null the same #17

Open
silverwind opened this issue Dec 18, 2022 · 1 comment
Open

Option to treat 0 and null the same #17

silverwind opened this issue Dec 18, 2022 · 1 comment

Comments

@silverwind
Copy link

I think it does not make much sense to treat 0 and null different like the module currently does.

If one wants to treat them the same using 7-color colorRange, there is a issue in the legend rendering when where the two colors are listed twice and the legend being cut-off because the module can not correctly handle 7 colors in it:

image

I think the only clean way to solve is to have a boolean option that makes 0 and null equal color so colorRange can be defined using six colors.

See go-gitea/gitea#22157 for more details and a workaround I've added to fix the legend rendering.

@razorness
Copy link
Owner

I will take a look into this. Thanks for opening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants