Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change instances of JSX.Element to React.ReactElement #1089

Closed
saurabhdaware opened this issue Mar 23, 2023 · 4 comments · Fixed by #1490
Closed

Change instances of JSX.Element to React.ReactElement #1089

saurabhdaware opened this issue Mar 23, 2023 · 4 comments · Fixed by #1490
Assignees
Labels
P1 Kinda Important

Comments

@saurabhdaware
Copy link
Member

I've been adding JSX.Element return type everywhere in my components lol. We need to change that to React.ReactElement during next major release.

Won't be any critical breaking change but we can do it during major release in case someone has written some typecheck code somewhere.

@saurabhdaware
Copy link
Member Author

Update: we decided to do this without breaking change

@chaitanyadeorukhkar
Copy link
Collaborator

@saurabhdaware why was this marked as a P0? is this having any direct impact on the consumers?

@chaitanyadeorukhkar chaitanyadeorukhkar added P1 Kinda Important and removed P0 Critical labels Jul 14, 2023
@saurabhdaware
Copy link
Member Author

Nope. low effort tasks were marked as P0s

@snitin315 snitin315 assigned snitin315 and unassigned saurabhdaware Jul 25, 2023
@snitin315
Copy link
Member

snitin315 commented Jul 31, 2023

@saurabhdaware So we need to update all the instances of JSX.Element, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Kinda Important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants