Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some ifsc codes giving branch names containing special characters #16

Closed
sriksm19 opened this issue Mar 1, 2018 · 5 comments
Closed

Comments

@sriksm19
Copy link

sriksm19 commented Mar 1, 2018

this one is for ICIC0006255. instead of MYSORE MAIN it has an additional á.

image

Would give you more soon if encountered.

@sriksm19
Copy link
Author

sriksm19 commented Mar 1, 2018

just saw your ICICI.json file. looks like its almost everywhere in it
image

@captn3m0
Copy link
Contributor

captn3m0 commented Mar 2, 2018

This is an encoding issue at RBI end. You can verify this by downloading the original RBI excel sheets as well.

See razorpay/ifsc#32 and razorpay/ifsc#29

If you have a suggestion on how this can be handled cleanly, feedback is welcome 👍

@captn3m0 captn3m0 closed this as completed Mar 2, 2018
@sriksm19
Copy link
Author

sriksm19 commented Mar 2, 2018

https://stackoverflow.com/questions/10207354/how-to-remove-all-of-the-diacritics-from-a-file
would this help? (probably replace the diacritic with space or empty char)

or
https://stackoverflow.com/questions/3264915/remove-non-ascii-characters-in-a-file ?

PS: i havent written bash codes .. yet..

PPS: + i just mailed rbi regd this issue.. hope they check and correct it in this century

@captn3m0
Copy link
Contributor

captn3m0 commented Mar 5, 2018

These are all encoding issues. Likely newlines and other characters getting converted. However, I'd rather have RBI fix these at their end.

@captn3m0
Copy link
Contributor

RBI doesn't seem to be keen to fix these, so these are now cleaned up in the release. Accuracy is not guaranteed, but if you notice an issue starting from 1.5.13 release - please create a new issue.

Note that the changes aren't live at ifsc.razorpay.com yet, but should be there soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants