Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn add react-native-razorpay updates my project's yarn.lock #144

Closed
GaudamThiyagarajan opened this issue Jan 3, 2019 · 6 comments
Closed

Comments

@GaudamThiyagarajan
Copy link

Before razorpay installation
react native@55.x and metro@0.30.x and babel@6.x.x

After razorpay sdk installation in yarn.lock we get two react-native of different versions
on react-native-razorpay/master we are getting two versions
react-native@55.x and react-native@0.57.0

on react-native-razorpay/2.0.10 we are getting two versions
react-native@55.x and react-native@>=0.55.0

Our own metro bundler and babel are getting updated to razorpay's package.json
How to avoid these unnecessary updates

@iThink32
Copy link
Contributor

iThink32 commented Jan 4, 2019

@GaudamThiyagarajan move the dependencies in the package.json of react-native-razorpay to devDependencies (yet to try out but according to my research it is the cause of this issue).Have a look at this link

https://stackoverflow.com/questions/18875674/whats-the-difference-between-dependencies-devdependencies-and-peerdependencies

and make sure you update your react-native and react version in your main package.json

@GaudamThiyagarajan
Copy link
Author

GaudamThiyagarajan commented Jan 5, 2019

Updating from 0.55 to 0.57 is not a simple task. We have to look upgrade related to babel@7 and other dependency changes is there a simpler way to support 0.55. Why does react-native-razorpay@2.0.10 also adds additional reactnative linking to 0.57 when razorpay's package.json says (@>=0.55)

@GaudamThiyagarajan
Copy link
Author

I forked your repo and downgraded the react to 0.55.4 and react to 16.3.1 and used that. This package doesn't need react native 0.57.x

@iThink32
Copy link
Contributor

iThink32 commented Jan 7, 2019

@GaudamThiyagarajan the fact behind this is react-native on Xcode 10 is unstable , they are still making fixes for it , it is highly recommended that you use the latest version of react-native as it contains a lot of Xcode 10 fixes.

@GaudamThiyagarajan
Copy link
Author

Since we are working with only react-native for android would it still be a problem?

@iThink32
Copy link
Contributor

iThink32 commented Jan 8, 2019

@GaudamThiyagarajan I don't think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants