Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it support MIDI channels? #11

Open
damirka opened this issue Nov 13, 2020 · 3 comments
Open

Does it support MIDI channels? #11

damirka opened this issue Nov 13, 2020 · 3 comments

Comments

@damirka
Copy link

damirka commented Nov 13, 2020

Hello there. Maybe I'm too new in C++ world, but by looking at source code I haven't found MIDI channelling anywhere. Can you help me do this?

@razrotenberg
Copy link
Owner

Hi @damirka and thanks for reaching out!
So I personally didn't need to control the MIDI channel and just used channel 0 hard coded.
This could be easily changed though.
All there needs to be done is propagate a variable all the way to send() method in midi.cpp instead of the hard coded value (https://github.com/levosos/Midier/blob/master/src/midi/midi.cpp#L17).

Let me know if you want to open a pull request with these changes or if I can help you doing that!

@damirka
Copy link
Author

damirka commented Nov 22, 2020

Okay @levosos, let's do it this way: I'll make my first PR on C++, and if there's something wrong you'll help me fix this. 😆

@razrotenberg
Copy link
Owner

No problem :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants