Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed matches are no longer recognized, probably because of the log file change #403

Closed
bobanm opened this issue May 8, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bobanm
Copy link

bobanm commented May 8, 2024

Detailed context

Your Desktop:

  • OS: Windows 11
  • App type: Standalone
  • App Version: 2.2.30

Describe the bug

Since the latest update from 7 May, the completed matches are no longer recognized by the app. I noticed that Arena once again populates the log file with usernames in short format, without numbers. E.g. instead of username#12345 for most of the entries it only shows username. This happened already when update of 26 March introduced the same log file change, but Arena reverted that change in a later update.

I don't know if Wizards want to populate the log file with short or long username format. Rumors are they want to switch to short format, to prevent users from sending friend requests after completing a match, by reading the full username from the log. For MTGA Pro, I think it would be the best and future-proof solution to modify the code to match its users based on a short username format. Untapped.gg still works correctly and I don't think they use long format of Arena usernames.

To Reproduce
Steps to reproduce the behavior:

  1. Play a match in the Arena
  2. Verify that the log has been parsed
  3. Go to https://mtgarena.pro/matches/ or https://mtgarena.pro/u/
  4. The match is not registered

Except for missing matches, everything else seems to work OK. Collection is updating and Profile page shows new cards obtained.

@bobanm bobanm added the bug Something isn't working label May 8, 2024
@Revilak
Copy link

Revilak commented May 9, 2024

Hello,
about this problem Razviar replied on Discord server that the issue might be harder to fix .

@bobanm
Copy link
Author

bobanm commented May 28, 2024

Fixed in 2.2.31, with explanation that @Razviar provided in Discord:

It was a nasty one, the issue was inside injected part of the code, related to serialization error due to internal game changes. So wasn't even about log changes. Version 2.2.31 should be tracking matches as ususal

@bobanm bobanm closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants