Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The behavior of cshap_ls on neovim 0.7 is abnormal #31

Closed
Decodetalkers opened this issue Apr 17, 2022 · 7 comments
Closed

The behavior of cshap_ls on neovim 0.7 is abnormal #31

Decodetalkers opened this issue Apr 17, 2022 · 7 comments

Comments

@Decodetalkers
Copy link
Contributor

I think I would better also mention this here. I am confused.. Before 0.7 it works well. I cannot figure out how it comes.
neovim/neovim#18147

@razzmatazz
Copy link
Owner

I am still on a vacation for a while (until next week) -- will take a look then

@Decodetalkers
Copy link
Contributor Author

Hello ,any update?

@razzmatazz
Copy link
Owner

Sorry, busy with other things. I don't have nvim setup myself yet.

@razzmatazz
Copy link
Owner

razzmatazz commented May 18, 2022

ok, I wrote the same thing to neovim/neovim#18147 but here it follows:


Hmm, I believe csharp-ls has broken behaviour wr.t. incremental sync..

I was trying to replicate the problem and managed to setup packer+nvim-lspconfig and immediately hit the problem where typing things too fast in nvim triggers document sync problems.

My plan here is to:

  • update csharp-ls to properly handle full sync behaviour from the client (via negotation)
  • add a command line param to force full sync
  • add a PR to nvim-lspconfig to set this param until we have this partial sync bug diagnosed (whether this is csharp-ls or nvim at fault)
  • fix the actual problem

@razzmatazz
Copy link
Owner

razzmatazz commented May 19, 2022

Hey @Decodetalkers sorry for taking this long.

I think I have fixed the bug with 396387c -- it was actually a problem with how csharp-ls was handling incremental file changes. At least for me typing fast in nvim does not cause sync errors anymore, so hopefully your problem with formatting is fixed too. Please confirm if so.

I have released a new version of csharp-ls:

@Decodetalkers
Copy link
Contributor Author

Hey @Decodetalkers sorry for taking this long.

I think I have fixed the bug with 396387c -- it was actually a problem with how csharp-ls was handling incremental file changes. At least for me typing fast in nvim does not cause sync errors anymore, so hopefully your problem with formatting is fixed too. Please confirm if so.

I have released a new version of csharp-ls:

Yes, fixed

@razzmatazz
Copy link
Owner

Closing this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants