Order of suggestions of code-fixes is not really optimized, especially with imports

[josteink]

Consider the following code:

a/Class1.cs

namespace A
{
    public class Class1
    {
        // code
    }
}

b/Class2.cs

namespace B
{
    public class Class2
    {
        var instance = new Class1();
    }
}

Then put your cursor on Class1() and invoke M-x lsp-execute-code-action in Emacs, or similar action in other editor.

Observed that

You will be provided several different options:

(Screenshot for demonstrationg-purposes. Does not match example code 1-to-1)

Expected that

Generally, in my experience, some actions are almost always "more" preferred than others.

In this particular case I almost always want to have using-statements as first suggestion, explicit-namespacing as second and create new class as third and expect to find code-fixes in that order.

Does the LSP protocol provide any sort of ... priority for the code actions or is it up to the LSP-client itself to determine how to present them?

[razzmatazz]

It looks like there is :) I thought there wasnt.

‘CodeAction.isPreferred’
https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#codeAction

[josteink]

On the same spec there’s also CodeActionKind:

kind?: CodeActionKind;

It seems one possible value for that is quickfix.

So I guess we should prioritise isPreferred and quickfix-kind actions, and in that order?

[razzmatazz]

pending on ionide/LanguageServerProtocol#4

[razzmatazz]

pending on ionide/LanguageServerProtocol#4

ok, that one has been merged

[razzmatazz]

I have published 0.1.8, which should pull usings action up a bit, not 100% sure this was the right way to fix, as isPreffered was not taken into account in emacs-lsp/lsp-mode at the time I was checking it so not only that but I sorted simply those actions before returing to the editor -- hopefully ergonomics are better now

(it might take a couple of minutes for the package to show up on https://www.nuget.org/packages/csharp-ls/0.1.8)

[josteink]

Tested and works. Great stuff! 😃

Edit: Proof!

[josteink]

This works 100% as I described in the "expected" section in the issue, so I guess I have no choice but consider this 100% resolved 😄