-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search bar in action bar #14
Comments
I don't understand. Are you saying hide the search icon in the action bar on the main activity? |
Yes, until the user presses the search button on the main screen. If the user cancels a search by pressing the X symbol, then it will be hidden again. This is mainly for the main screen. |
Sure. |
There's another thing that we should think of. The blue search button is visible when the android keyboard pops up. We could ...
|
I am not really sure. If we make the buttons disapear, it would disrupt the layout. If the buttons are moved lower, there seems to be too much white space towards the center of the page. Would it be possible to make the search button do a search, once the search field becomes visible for typing? Another idea is to start a new activity with only a search bar, or have the search bar appear right above the buttons on the main screen, similar to google's homepage, but this seems kind of cheesy. |
|
|
You're right.
I'm now leaning towards (2) because the user can click on randomButton and be able to launch Random Quote Activity while searchView is iconified. Or we could always not let the user be able to launch the activity while searchView is iconified, but this is kind of a step back. |
(2) sounds good. To clarify, so when the user presses the search button after entering something, the specific quote activity is launched? |
No. Currently the onClickListener of searchButton will only open the searchView (set isIconified to false). The specific quote activity is currently being launched by the onQueryTextSubmit of the onQueryTextListener of the searchView |
What do you think about hiding the search bar in the action bar until the user clicks the search button at the center of the page (on the main screen). With the setup right now, it is slightly redundant. Also, this could free up space for other things like sharing buttons. Once the user clicks the search button, any existing items that take up too much space in the action bar will be hidden and replaced by the full search bar. If the user cancels the search, then any items previously hidden will become un-hidden.
The text was updated successfully, but these errors were encountered: