Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_pdf_renderer] Transfer the bitmap through a temporary file #150

Open
graknol opened this issue Jan 25, 2021 · 4 comments
Open

[native_pdf_renderer] Transfer the bitmap through a temporary file #150

graknol opened this issue Jan 25, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@graknol
Copy link

graknol commented Jan 25, 2021

Is your feature request related to a problem? Please describe.
When rendering big PDFs or at big resolutions, the PlatformChannel takes a long time/crashes the app.

The PlatformChannel requires the UI thread, which means we shouldn't be transferring big files as base64-encoded JSON through it.

Describe the solution you'd like
At least the iOS and Android targets should create temporary files, then pass the path to this file in the response message.

Don't know how the web target works, so can't speak for that.

@graknol graknol added the enhancement New feature or request label Jan 25, 2021
@graknol
Copy link
Author

graknol commented Jan 25, 2021

I'm taking a stab at the Android target.

@SergeShkurko
Copy link
Member

#153

@SergeShkurko
Copy link
Member

In you fork files location has broken: #153 (comment)

@SergeShkurko
Copy link
Member

I resolve any problems at: #230
based on you changes but w/o commit history (i migrate files by hand)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants