Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_pdf_renderer] Windows implementation #174

Merged
merged 18 commits into from Apr 7, 2021

Conversation

Jon-Salmon
Copy link
Contributor

I believe this windows implementation implements all functionality currently supported by native_pdf_renderer

@Jon-Salmon
Copy link
Contributor Author

The files failing the formatting CI stage are the unedited windows example bootstrapping files generated by the flutter tool. Could re-format them but excluding them from the CI format stage may a better option.

@SergeShkurko SergeShkurko changed the base branch from master to develop April 7, 2021 15:37
@SergeShkurko SergeShkurko merged commit ba142a8 into ScerIO:develop Apr 7, 2021
@SergeShkurko
Copy link
Member

@Jon-Salmon thanks for you contribution!

@SergeShkurko
Copy link
Member

@Jon-Salmon after check i got error:
image

from here
https://github.com/rbcprolabs/packages.flutter/blob/ba142a8934cd858cce5252467ddd618e2da34b6d/packages/native_pdf_renderer/windows/DownloadProject.cmake#L179

verbbose:
image

Flutter:

Flutter 2.0.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision adc687823a (13 days ago) • 2021-04-16 09:40:20 -0700
Engine • revision b09f014e96
Tools • Dart 2.12.3

System:

version: win10 20H2
build: 19042.928

@SergeShkurko
Copy link
Member

For next i see not exists binary in releases
image

and replace here
https://github.com/rbcprolabs/packages.flutter/blob/ba142a8934cd858cce5252467ddd618e2da34b6d/packages/native_pdf_renderer/windows/CMakeLists.txt#L13

link to latest stable release with binary for windows
https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F4475/pdfium-windows-x64.zip

run and got a another error:
image
"выход из программы" - exit from programm
"с кодом" - with code

but my another flutter windows application works normally on it PC:
image

@SergeShkurko
Copy link
Member

hmm, works only when i run with administrator privilegies

@Jon-Salmon
Copy link
Contributor Author

Good spot with the pdfium releases, could go for something like this Jon-Salmon@c4d54cc (inspired by the flutter printing package).

I didn't find that I needed to run as admin, I can try things next week.

@Jon-Salmon
Copy link
Contributor Author

@SergeShkurko I've just tested and the running the develop branch works fine on my machine without admin previliges. Looking at this stack overflow post, it looks like it might be due to your local folder permissions: https://stackoverflow.com/questions/31457306/visual-studio-msb3073-error-exited-with-code-1

Does deleting the build folder and re-running help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants