-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stacked headings create invalid EPUB #1647
Comments
Is it specifically the |
Yes, it is the Error message:
So at line 84, column 524 (during some cover image testing). |
The problem with using Best idea at present is to use |
Wait, is |
I'm changing how the stacked duplicate headings come out in HTML. I've currently got it like:
I'm listening to Apple VoiceOver, and it's interesting. First, it announces that the heading has "9 items". So it's counting all 9 of those spans. This is not good. The next thing is that after it reads all of the content, it concludes by repeating that we are on a heading level 3, and then it reads the title text. That essentially just repeats the information that we just read. It does pause with each span. This runs contrary to my previous understanding of how a screenreader sees a I can only test with Apple VoiceOver. Really, I should be experiencing what JAWS, NVDA, and ChromeVox do too. Any objection to: This is all only for duplicate headings that arise in Stepping back a bit, this suggests we need to be more careful about using |
Sorry for the delay. Going in multiple directions the past 24 hours.
The
I think that is fine here as well. The purpose is to get tooltips.
That's one (opinionated) person eight years ago. ;-) So I'd be interested in more modern recommendations. But what I'd really like to do is use the ARIA scheme to override all the old practices. Maybe UTMOST can support somebody who wants to do that. ;-) Observation: EPUB will need to be XHTML. Be sure your |
a) I turn it into 3 spans instead of 9? (If so, with a new class?)
The span.codenumber is used so we can turn off numbers as part of styling. I think they are necessary here.
So I think 3 spans would be fine. But I'd rather @davidfarmer checks off, especially if we introduce a new
class.
I don't see why we would custom style those stacked headings
(this is for collected items at the end, right?).
So you can just put what should be there: a space is just a space,
not a space in a span.space . A codenumber is just a number which will
always be visible.
I think I am saying yes to one span per line.
Not sure about the relative merits of < br > vs. styling those
spans as blocks.
|
The EPUB validator complained about the content of the |
I have, and it is an HTML problem too.
I will watch that. I was copy-pasting from the inspector, which may have dropped the closing |
#1668 should fix this. |
Closed via #1668. Just to be certain, checked that EPUB validation problems have gone away. Thanks, @Alex-Jordan! |
The backmatter figure list and solutions of the
epub-sampler
has the new stacked headings. But in an EPUB the validator does not like thep.assistive
in anh3
(I think). Pinging @mitchkeller so he is aware.From (possibly):
Thoughts:
span
, or similar, and style as a block element?The text was updated successfully, but these errors were encountered: